> CDS heap dumping was manually disabled in lworld due to the method in which 
> the migrated value classes were added to the JDK. Migrated value classes were 
> added through module patching which is incompatible with CDS heap dumping, 
> but now since they are added through jimage, we can re-enable CDS heap 
> dumping and related features that rely on it.
> 
> AOT adds some complexity to this as it loads and links classes in VM startup, 
> so alternate code paths need to be considered. Signature calling conventions 
> are stored in adapters which are archived in the AOT code cache, but they 
> aren't usable at runtime, so they need to be regenerated even if we don't 
> regenerate the adapters.

Matias Saavedra Silva has updated the pull request with a new target base due 
to a merge or a rebase. The pull request now contains 11 commits:

 - Merge branch 'lworld' into enable_cds_heap
 - Merge branch 'lworld' into enable_cds_heap
 - Reverted preview patching flag
 - Fred comment
 - Removed test from group
 - Merge branch 'lworld' into enable_cds_heap
 - Merge branch 'lworld' into enable_cds_heap
 - Properly rewrite fast_vputfield and fast_vgetfield
 - Merge branch 'lworld' into enable_cds_heap
 - Merge branch 'lworld' into enable_cds_heap
 - ... and 1 more: https://git.openjdk.org/valhalla/compare/d586e57d...12219718

-------------

Changes: https://git.openjdk.org/valhalla/pull/1757/files
  Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=1757&range=02
  Stats: 69 lines in 8 files changed: 37 ins; 28 del; 4 mod
  Patch: https://git.openjdk.org/valhalla/pull/1757.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1757/head:pull/1757

PR: https://git.openjdk.org/valhalla/pull/1757

Reply via email to