On Tue, 16 Dec 2025 08:51:59 GMT, Tobias Hartmann <[email protected]> wrote:
>> Damon Fenacci has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8369045: remove strength reduction flag > > src/hotspot/share/opto/graphKit.cpp line 2051: > >> 2049: _gvn.set_type(ret, ret->Value(&_gvn)); >> 2050: >> 2051: // Don't add store to buffer call if we are strength reducing > > Why do we need to add the above runtime check of the result again when doing > strength reduction? We actually don't 🙂 I moved it inside the not-strength-reducing block. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1768#discussion_r2627420774
