On Wed, 17 Dec 2025 13:33:25 GMT, Jan Lahoda <[email protected]> wrote:
> Fixing `test/langtools/tools/javac/diags/CheckExamples.java` > (`test/langtools/tools/javac/diags/examples/PrimitivePatternMatching.java`) > and `test/langtools/tools/javac/preview/PreviewAutoSuppress.java` tests. > > Unfortunately, it is quite hard to make the tests work both with and without > `-DDISABLE_PREVIEW_PATCHING=true` (could be done for > `PreviewAutoSuppress.java`, but it is very hard to do sensible for > `CheckExamples.java`), so given the future is > `-DDISABLE_PREVIEW_PATCHING=true`, this change forces this option. (The > practical impact of testing only this variant for these two tests is > basically zero, I think. We have a different test that verifies all the > combinations.) FYI, these tests were problemlisted, among many others, in #1815 to address noise issues. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1813#issuecomment-3665638510
