On Wed, 17 Dec 2025 14:04:08 GMT, Stefan Karlsson <[email protected]> wrote:
>> src/hotspot/share/oops/inlineKlass.hpp line 53: >> >>> 51: // features (see InstanceKlass::size). Therefore, we can't put C++ >>> fields >>> 52: // directly into the InlineKlass class, but instead we stamp out a >>> block of >>> 53: // these members after the part of the object that comes from the >>> InstanceKlass. >> >> Suggestion: clarify in the comment that the goal was to have the same offset >> for the vtable in both InstanceKlass and InlineKlass, so the vtable could be >> accessed without having to differentiate between the two kinds of Klass. >> >> Otherwise, nice rework! > > Thanks! I've updated the comment to go into more details. Please, take a look > and see if this is better. Thank you for the comment update. The rational behind the InlineKlass::Member is made very clear. Ship it! ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1812#discussion_r2627300207
