On Mon, 15 Dec 2025 19:46:03 GMT, Paul Hübner <[email protected]> wrote:
>> Hi all, >> >> This removes the `EnableValhalla` in favour of the `--enable-preview` flag. >> Concretely: >> * I've replaced most of the `EnableValhalla` checks with >> `Arguments::is_valhalla_enabled()`. >> * Some checks were redundant and could be removed entirely. >> * I've made the `EnableValhalla` flag obsolete. >> * Some tests had to be updated. >> >> This greatly changes the semantics of tests. I've refined some test groups >> to make it easier. >> >> Testing: tiers 1-4. > > Paul Hübner has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 23 commits: > > - Use the new function for the Parallel changes. > - Merge branch 'lworld' into JDK-8371357 > - Remove wrong comment. > - Fix imports. > - Reviewer comments. > - Copyright. > - Revert "Don't synchronize on Double." > > This reverts commit cbf849c2ce6059af2b43b3dd8cb42445eab4df2b. > - Accidentally changed too many enable_preview. > - Make heap dump test require debug VM. > - Change to arguments. > - ... and 13 more: > https://git.openjdk.org/valhalla/compare/8c0c190b...58fb031a Now that we're not using EnableValhalla, which was in runtime/globals.hpp, there are several includes of runtime/globals.hpp which have been added over the years in the lworld branch that don't need to be added anymore. I don't see an issue with including runtime/globals.hpp unnecessarily, just pointing it out. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1759#issuecomment-3659588591
