On Mon, 15 Dec 2025 21:36:37 GMT, Stefan Karlsson <[email protected]> wrote:

>> The lworld branch has support for null-restricted arrays, and to support 
>> this code has been adjacent to the code that perform array copy check casts. 
>> The code that performs the check casts used to be located inside the GC 
>> access barriers, but the code that finally threw exceptions were located in 
>> the runtime code. In the lworld branch the code that throws the check cast 
>> exception and the new null pointer exception has been moved into the GC 
>> access barriers.
>> 
>> I propose that we revert back to the old style where the exception throwing 
>> was somewhat decoupled from the GC access barriers.
>
> Stefan Karlsson has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Comment at nodiscard

looks good to me - thanks for adding the comment!

-------------

Marked as reviewed by heidinga (no project role).

PR Review: 
https://git.openjdk.org/valhalla/pull/1792#pullrequestreview-3580363881

Reply via email to