On Fri, 5 Dec 2025 07:31:35 GMT, Quan Anh Mai <[email protected]> wrote:
>> Hi, >> >> This PR fixes various issues with `TypeAryPtr` and `TypeAryKlassPtr`. It >> starts with me trying to tighten the properties (`flat`, `null_free`, etc) >> of these classes, then fixing all the revealed issues until there are no >> crashes or wrong results left. >> >> Please take a look and leave your reviews, thanks a lot. > > Quan Anh Mai has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains seven commits: > > - Merge branch 'lworld' into AryKlassPtrfactory > - Fix Parse::array_store and PhaseMacroNode::value_from_mem > - whitespace > - fix more issues > - Merge branch 'lworld' into AryKlassPtrfactory > - Fix test failures > - Tighten the type system around array properties and fix related issues Thanks Tobias, the first issue is due to a wrong `if` in `Parse::array_store` which skips the whole `if (!array_type->is_not_flat())` if the array is null-free. The second issue is that the `AllocateNode::InitValue` of an `AllocateArrayNode` is the output of the call to `Class::new_instance`, which is of type `j.l.Object`, we should bail out if we cannot see through the value object, then. For the OOM, on my machine both lworld and this branch fail with `-Xmx20m` and pass with `-Xmx21m`. Seems like it is on the edge there. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1755#issuecomment-3615669911
