On Fri, 21 Nov 2025 16:00:08 GMT, Coleen Phillimore <[email protected]> wrote:
> This looks good. Did you have a jvmci change still? Nope, I shouldn't need to change `ciField` anymore as far as I can tell, and Fred agrees. But thanks for being vigilant! > src/hotspot/share/oops/flatArrayOop.inline.hpp line 42: > >> 40: >> 41: address addr = (address) base(); >> 42: addr += (index << Klass::layout_helper_log2_element_size(lh)); > > Because index is an int, this could go negative right? Yep. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1752#issuecomment-3563694052 PR Review Comment: https://git.openjdk.org/valhalla/pull/1752#discussion_r2550257025
