On Fri, 21 Nov 2025 08:35:15 GMT, Tobias Hartmann <[email protected]> wrote:
> Naming is fine with me but do we even need to factor this logic out? Do you > expect it to be used in more places in the future? I suspect we might need a similar thing in virtual threads. I've seen other places where we do this trick of finding the increment and fixing the framesize to find the sp of the caller. For instance https://github.com/openjdk/valhalla/blob/lworld/src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp#L56-L81 (and I'm underwhelmed Github doesn't render the link as a code block) looks a lot like what was in `sender_for_compiled_frame` that I've extracted. I think it's a bit subtle and worth delegating to a common method. It is true, it uses `repair_sender_sp` but so does my new `compiled_frame_details` and there is still work to do around. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1751#issuecomment-3562048781
