On Thu, 20 Nov 2025 15:12:09 GMT, Frederic Parain <[email protected]> wrote:
>> Add some helper methods to test properties of layouts in a more reliable way.
>>
>> Tested with Mach5, tier 1 to 3.
>>
>> Fred
>
> Frederic Parain has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix ArrayProperties for NULLABLE_ATOMIC_FLAT
src/hotspot/share/oops/arrayKlass.hpp line 42:
> 40: public:
> 41: enum ArrayProperties : uint32_t {
> 42: DEFAULT = 0, // NULLABLE and ATOMIC
Does DEFAULT also apply to arrays of oops? The name "DEFAULT" is slightly
concerning if we're only talking about non-oop cases. I'd be tempted to call
this NULLABLE_ATOMIC rather than DEFAULT
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1745#discussion_r2547335427
