On Tue, 18 Nov 2025 21:56:57 GMT, David Beaumont <[email protected]> wrote:

>> Copies valuetype classes for each module into corresponding 
>> "/META-INF/preview/..." sub-directories to be pulled into jimage files and 
>> processed by the new preview mode handling code.
>> 
>> There might be a better way to do this in terms of Makefile semantics, but 
>> this seems to work well enough and doesn't prevent the value-class JAR files 
>> being generated for patching (which is still how everyone will get value 
>> classes until the rest of the work is plumbed in).
>> 
>> To enable the new preview mode work, set the "DISABLE_PREVIEW_PATCHING" 
>> system property to "true".
>
> David Beaumont has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains four additional 
> commits since the last revision:
> 
>  - Merge branch 'lworld' into jdk_8368475_makefile/squashed
>  - rename marker, tweak comments
>  - Merge branch 'lworld' into jdk_8368475_makefile/squashed
>  - Copy value classes into preview directories for inclusion in jimage

I know it's working once the system property is changed. As it stands this 
should have no impact other than adding some unused entries into the jimage 
file.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1727#issuecomment-3549641479

Reply via email to