On Tue, 4 Nov 2025 17:08:45 GMT, David Beaumont <[email protected]> wrote:
> Adds support for writing preview related flags into jimage files. > > Preview mode is complex. It's not nearly as simple as "does something in > /modules/xxx/... have an entry in /modules/xxx/META-INF/preview/...". > > Specific issues include: > > Supporting preview-only resources without forcing a double lookup on > everything. > Changing the set of entries in /packages/xxx directories to account for > preview only packages in some modules. > Minimising the work done during image reader initialization to only need to > process the small number of preview resources (rather than scanning the whole > file to look for them). > The new flags added by this code address these issues, but calculating them > correctly with only minor adjustments to the existing code was not feasible, > it just became a lot larger and very complex. > > To address this, a new type (ModuleReference) is introduced to track and then > merge information about packages seen in each module. This allows a much > simpler inner loop for processing resource paths when building the node tree, > combined with a subsequent merging stage to produce the final package > information for each module. > > Not that since ModuleReference is needed during jimage reading, that class is > already present in the previous PR on which this is based, but it starts to > be used to calculate the module flags in this PR. > > This PR can also adds the ImageReader unit tests for preview mode, which rely > on being able to generate jimage files with preview mode flags in. This pull request has now been integrated. Changeset: 72539b57 Author: David Beaumont <[email protected]> Committer: Roger Riggs <[email protected]> URL: https://git.openjdk.org/valhalla/commit/72539b57d088940bc18185d1658db6c89f4033fc Stats: 2089 lines in 16 files changed: 893 ins; 163 del; 1033 mod 8368467: [lworld] Add new flag generation for jimage to support preview mode Reviewed-by: rriggs ------------- PR: https://git.openjdk.org/valhalla/pull/1718
