On Thu, 6 Nov 2025 22:33:11 GMT, Roger Riggs <[email protected]> wrote:
>> David Beaumont has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> Rollup of makefile changes and jlink fix (temp). >> >> * likely test fix >> * Copy value classes into preview directories for inclusion in jimage > > src/java.base/share/classes/jdk/internal/jimage/ResourceEntries.java line 24: > >> 22: * Returns the full entry names for all resources in the given >> module, in >> 23: * random order. Entry names will always be prefixed by the given >> module >> 24: * name (e.g. "/<module-name/..."). > > Are these names useful with any ImageReader api other than > ResourceEntries.sizeOf or open? Yes, they are just the well defined jimage names for things (think similar to JAR entry names). I tweaked the wording in 1721 to refer to them as "jimage names". > src/java.base/share/classes/jdk/internal/jimage/ResourceEntries.java line 26: > >> 24: * name (e.g. "/<module-name/..."). >> 25: */ >> 26: Stream<String> entryNamesIn(String module); > > A cleaner name would be `entryNames`. Changed to getEntryNames() and getSize() in 1721. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1719#discussion_r2503891128 PR Review Comment: https://git.openjdk.org/valhalla/pull/1719#discussion_r2503886149
