On Thu, 30 Oct 2025 16:42:56 GMT, David Beaumont <[email protected]> wrote:

>> Java changes for supporting preview mode when preview mode resources (with 
>> new location flags) are available.
>> 
>> At the moment, this code will operate on non-preview jimage files (1.0) and 
>> act as if no preview resources are available by virtue of the default value 
>> for missing attributes and package flags being zero (which matches jimage 
>> 1.0).
>> 
>> This should be reviewed on top of 
>> https://github.com/openjdk/valhalla/pull/1618
>
> David Beaumont has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains six additional 
> commits since the last revision:
> 
>  - Merge branch 'lworld' into jdk_8368333_java/squashed
>  - remove preview only entries when completing directories
>  - remove ImageReaderFactory.java (again)
>  - Reapplying feedback changes.
>  - feedback changes
>  - Resync after dependent PR submit.
>    
>    * Removing package root flag based on feedback.
>    * Changing existing package flags during writing to match altered flag 
> values.
>    * Feedback changes, and fixing some comments.
>    * Renaming slightly confusing "testEncoder" method.
>    * Fixing unit tests to use new constructor.
>    * Word smithing flags definitions.
>    * Add workaround until new image writing code is in
>    * Clarifying flag docs for /packages/xxx case
>    * Java ImageReader changes for preview mode

@david-beaumont 
Your change (at version 78f78354f0cdc14b38417495a202a404e2366cef) is now ready 
to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1619#issuecomment-3473751692

Reply via email to