On Fri, 10 Oct 2025 09:22:01 GMT, Tobias Hartmann <[email protected]> wrote:
> This is a follow-up from > [JDK-8366705](https://bugs.openjdk.org/browse/JDK-8366705) resolving a large > number of ToDos in the implementation and tests. > > There are a few remaining ToDos that I'll address with > [JDK-8370341](https://bugs.openjdk.org/browse/JDK-8370341) because this > change is getting too large and is blocking other work. > > Best regards, > Tobias Runtime changes look good to me. src/hotspot/share/oops/objArrayKlass.cpp line 391: > 389: // C2 relies on this for a fast lookup (see > LibraryCallKit::load_default_refined_array_klass). > 390: if (ak == nullptr) { > 391: klass_with_properties(ArrayKlass::ArrayProperties::DEFAULT, > THREAD); This call modifies the next_refined_array_klass pointer, which makes test on line 395 operating on an obsolete value. Not a semantic issue considering the case being handled, but not a good coding practice. Could you move this code inside the block where the MultiArray_lock is already owned? ------------- Marked as reviewed by fparain (Committer). PR Review: https://git.openjdk.org/valhalla/pull/1672#pullrequestreview-3340253370 PR Review Comment: https://git.openjdk.org/valhalla/pull/1672#discussion_r2426391506
