On Tue, 21 Oct 2025 08:22:10 GMT, Marc Chevalier <[email protected]> wrote:

>> Various cleanup in test package `compiler.valhalla.inlinetypes`:
>> - rename duplicated classes so that IDEs are nice, resolve correctly. New 
>> names are a bit... arbitrary. I'm happy to rename name if anyone has 
>> opinions. When writing new tests, let's prefer nested classes if we can.
>> - add `package compiler.valhalla.inlinetypes;` where it was missing. IDEs 
>> like that, and I vaguely remember we should.
>> - fix flags to take the new path into account, new package, or class 
>> renaming. Please, try to pay attention to that: I've did multiple passes to 
>> catch'em all, but this is easy to miss.
>> - remove some useless `import`.
>> - some few typos in comments.
>> - maybe more?
>> 
>> Thanks,
>> Marc
>
> Marc Chevalier has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains six commits:
> 
>  - Merge remote-tracking branch 'upstream/lworld' into JDK-8368988
>  - More consistent naming convention
>  - Merge remote-tracking branch 'origin/lworld' into JDK-8368988
>  - post rebase fixes
>  - Fixes
>  - Some cleanup

Thanks @TobiHartmann for the review!

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1683#issuecomment-3425825494

Reply via email to