On Wed, 24 Sep 2025 18:24:52 GMT, Roger Riggs <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Manually deleting ImageReaderFactory (it returned somehow) > > src/java.base/share/classes/jdk/internal/jimage/ImageLocation.java line 104: > >> 102: /** >> 103: * Helper function to calculate preview flags >> (ATTRIBUTE_PREVIEW_FLAGS). >> 104: * > > A summary of what gets what flags might be easier to read than the code. > Or list the flags and refer to their descriptions (that would describe the > paths where the flags would be found) Done in latest snapshot. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1619#discussion_r2415162998
