On Wed, 1 Oct 2025 20:47:10 GMT, Chen Liang <[email protected]> wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> do not generate proxy variables for warned code
>
> test/langtools/tools/javac/SuperInit/InitializationWarningTester.java line
> 143:
>
>> 141: javaFile = p;
>> 142: } else if (p.toString().endsWith("out")) {
>> 143: goldenFile = p;
>
> Can we just do `baseDir.resolve(className + ".java")`, and do a
> `Files.exists` check for the golden file, instead of having complicated stuf
> like this?
yep I wanted to clean that before pushing but then I forgot, thanks
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1650#discussion_r2399414143
