On Fri, 12 Sep 2025 16:14:26 GMT, Marc Chevalier <[email protected]> wrote:
>> test/hotspot/jtreg/compiler/valhalla/inlinetypes/RepairStackWithBigFrame.java >> line 35: >> >>> 33: * increment and rfp at the same time, since it only has a 7 >>> bit offset. >>> 34: * We use two ldr with 9-bit offsets instead. >>> 35: * @library /test/lib / >> >> Do you really need this? You do not seem to use anything from the library. > > I thought so too, and I tried without and it doesn't work. I'm using actually > `MyValue1` that is defined in the same package, as we do in a lot of valhalla > tests. And this one include a lot of things that needs both these paths (I've > tried with each alone). Without that, I would also not need `@modules java.base/jdk.internal.vm.annotation`. Alas, it seems needed... ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1575#discussion_r2344759720
