On Fri, 5 Sep 2025 19:51:00 GMT, Coleen Phillimore <[email protected]> wrote:
>> This change moves code back to match mainline that checks access flags and >> checks for invalid JVM_CONSTANTS_Module/Package before reading the class >> name out of the constant pool. >> Tested with tier1-3. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Remove extra error message printing for inner classes not in mainline. src/hotspot/share/classfile/classFileParser.cpp line 4465: > 4463: "Illegal class modifiers in class %s%s: 0x%X", > 4464: _class_name->as_C_string(), class_note, flags > 4465: ); By removing the special handling of inner classes, the exception will report the access flag issue on the wrong class. This is going to make debugging/troubleshooting harder. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1550#discussion_r2330725170
