ok Jakob, thanks for clarification. if we --no-extensible_ro_snapshot do this, will it have a any performance impact.
On Tue, Jun 3, 2025 at 4:01 PM Jakob Gruber <jgru...@chromium.org> wrote: > > > On Tue, Jun 3, 2025 at 12:17 PM Subash <subash2826...@gmail.com> wrote: > >> Hi Jakob Grube, >> >> I am not reusing isolate. Each js execution happens in its own >> isolate. But I have a threadpool that will reuse the thread. Means the same >> thread may create another isolate after it gets a chance again. >> I load the snapshot bytes into char* array. Each create the isolate i >> will copy the bytes and feed to startup data in CreateParams. >> > > With default settings, all Isolates within the same process will reuse > certain resources. Perhaps most importantly, ReadOnlySpace is reused. This > is why all snapshots used within the same process must have compatible RO > space layout. > > >> >> I am creating a snapshot using >> SnapshotCreator::CreateBlob(FunctionCodeHandling::kKeep). >> >> I will check with --no-extensible_ro_snapshot >> >> flags.append(" --no-extensible_ro_snapshot"); >> v8::V8::SetFlagsFromString(flags.c_str()); >> >> I am disabled like this. >> >> >> >> >> On Tue, Jun 3, 2025 at 1:01 PM Jakob Gruber <jgru...@chromium.org> wrote: >> >>> >>> >>> On Tue, Jun 3, 2025 at 8:29 AM Subash Durairaj <subash2826...@gmail.com> >>> wrote: >>> >>>> >>>> /lib/x86_64-linux-gnu/libc.so.6(+0x3bd60)[0x7fe7781b6d60] >>>> >>>> v8::internal::StringTableInsertionKeyC2EPNS0_7IsolateENS0_6HandleINS0_6StringEEENS0_27DeserializingUserCodeOptionE+0x1c)[0x55b7ef4e844c] >>>> >>>> v8::internal::StringTable::InsertForIsolateDeserializationIsolateERKSt6vectorINS0_6HandleINS0_6StringEEESaIS7_EE+0x74)[0x55b7ef416e14] >>>> >>>> v8::internal::SharedHeapDeserializer::DeserializeStringTableEv+0x93)[0x55b7ef4f80f3] >>>> >>>> v8::internal::SharedHeapDeserializer::DeserializeIntoIsolateEv+0x68)[0x55b7ef4f8448] >>>> v8::internal::Isolate::Init::SnapshotDataES3_S3_b+0xd0d)[0x55b7ef12e00d] >>>> v8::internal::Snapshot::InitializeEPNS0_7IsolateE+0x189)[0x55b7ef4f94b9] >>>> v8::Isolate::Initialize::CreateParamsE+0x193)[0x55b7ef08d243] >>>> v8::Isolate::New::CreateParamsE+0x22)[0x55b7ef08d532] >>>> >>>> >>>> Hi Team, i am getting this crash when creating a new isolate. >>>> >>>> i am embedded v8 and running as a server to provide js execution. >>>> i ran maximum of 100 isolates in parallel with two different >>>> snapshot. >>>> each execution choose any one of snapshot >>>> >>> >>> We've seen problems related to using different snapshots within the same >>> Isolate before. To rule this out, please try disabling the >>> `extensible_ro_snapshot` when building the snapshot, either by using the gn >>> flag: >>> >>> v8_enable_extensible_ro_snapshot=false >>> >>> or the runtime flag: >>> >>> --no-extensible_ro_snapshot >>> >>> Otherwise, we'll need more information about the crash. >>> >>> >>>> >>>> i am getting this crash randomly. wondering how to fix this >>>> >>>> Please give me the direction to fix this. >>>> >>>> -- >>>> -- >>>> v8-users mailing list >>>> v8-users@googlegroups.com >>>> http://groups.google.com/group/v8-users >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "v8-users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to v8-users+unsubscr...@googlegroups.com. >>>> To view this discussion visit >>>> https://groups.google.com/d/msgid/v8-users/06af6ec6-bb96-4c44-be9c-1a8001d45a7cn%40googlegroups.com >>>> <https://groups.google.com/d/msgid/v8-users/06af6ec6-bb96-4c44-be9c-1a8001d45a7cn%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> >>> -- >>> -- >>> v8-users mailing list >>> v8-users@googlegroups.com >>> http://groups.google.com/group/v8-users >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-users+unsubscr...@googlegroups.com. >>> To view this discussion visit >>> https://groups.google.com/d/msgid/v8-users/CAH3p7oNu1k%3DDMsg%2BEDtPMTg7iWS35Qgj%2B%2Ba-UEptEsLp5AeGWg%40mail.gmail.com >>> <https://groups.google.com/d/msgid/v8-users/CAH3p7oNu1k%3DDMsg%2BEDtPMTg7iWS35Qgj%2B%2Ba-UEptEsLp5AeGWg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> -- >> v8-users mailing list >> v8-users@googlegroups.com >> http://groups.google.com/group/v8-users >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-users+unsubscr...@googlegroups.com. >> To view this discussion visit >> https://groups.google.com/d/msgid/v8-users/CAG9ciqmsmaQ8X2hXyFhgXJSe%3Dg%2Bb00xGZr__7h7D2hqwi974BQ%40mail.gmail.com >> <https://groups.google.com/d/msgid/v8-users/CAG9ciqmsmaQ8X2hXyFhgXJSe%3Dg%2Bb00xGZr__7h7D2hqwi974BQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > > -- > -- > v8-users mailing list > v8-users@googlegroups.com > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-users+unsubscr...@googlegroups.com. > To view this discussion visit > https://groups.google.com/d/msgid/v8-users/CAH3p7oP5SMdagAT4P3N8WXMx7%2BhCT5RuzeG09zo2UOmherVSig%40mail.gmail.com > <https://groups.google.com/d/msgid/v8-users/CAH3p7oP5SMdagAT4P3N8WXMx7%2BhCT5RuzeG09zo2UOmherVSig%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/v8-users/CAG9ciqkjqnOWWuE8S70eCBkqMqu8Ckuu38pwu5ePr1G4Gt6%2B2g%40mail.gmail.com.