Hi Clemens, >Do you need us to merge that back to v8 11.1, or can you just disable that on your side until you upgrade to a recent version of v8? There's no need to merge the fix back to v8 11.1, as we've added preserve_most disablement to our set of V8 patches.
Thanks again! On Tuesday, February 21, 2023 at 11:12:52 AM UTC-5 clem...@google.com wrote: > On Wed, Feb 8, 2023 at 6:05 PM ClearScript Developers < > clearsc...@gmail.com> wrote: > >> Hi Clemens, >> >> >Which toolchain do you use where you see crashes? >> >> Our hack to retain compatibility with old distros is probably bogus and >> unsupported, so if you know of a better way, please share it :) >> >> Anyway, what we (try to) do is roll back V8's Linux build tools to their >> state as of the last version that supported Ubuntu 16.04 LTS with >> glibc-2.23. After running "gclient sync" normally, we reset the "build" and >> "tools/clang" repositories to specific commits, then use install-sysroot to >> install specific "last known good" sysroots. >> > > That indeed sounds like a case we don't really want to encourage :D > Anyway, we just landed a CL to restrict the use of preserve_most to clang > 17, which has a fix which we will start to rely on ( > https://reviews.llvm.org/D143425). That should also fix your use case. > Do you need us to merge that back to v8 11.1, or can you just disable that > on your side until you upgrade to a recent version of v8? > > >> >> Cheers! >> >> On Wednesday, February 8, 2023 at 6:33:44 AM UTC-5 clem...@google.com >> wrote: >> >>> Thanks for reaching out! Indeed, preserve_most support turned out to be >>> a bit incomplete, so we tried to restrict it to the most important >>> platforms and toolchains used for Chromium. It's restricted to clang >>> anyway, and I didn't find any relevant fixes since the introduction in >>> 2016. Which toolchain do you use where you see crashes? Maybe we can >>> restrict it further to the most recent clang versions. >>> >>> On Wed, Feb 8, 2023 at 7:25 AM Jakob Gruber <jgr...@chromium.org> wrote: >>> >>>> +cle...@chromium.org >>>> >>>> On Tue, Feb 7, 2023 at 3:55 PM ClearScript Developers < >>>> clearsc...@gmail.com> wrote: >>>> >>>>> Greetings! >>>>> >>>>> We've noticed that preserve_most was disabled >>>>> <https://chromium.googlesource.com/v8/v8.git/+/d0b1dac0f9f3c5c1bbf296bd84c8f362d4832a88> >>>>> >>>>> for Windows/arm64 on the 11.1 branch tip today. >>>>> >>>>> We'd actually been struggling with extreme instability in 11.1 release >>>>> builds on Linux x64, so we tried disabling preserve_most for *all* >>>>> platforms, and, surprisingly, that seems to have stabilized our Linux >>>>> builds completely. >>>>> >>>>> So, it would appear that preserve_most issues go beyond Windows/arm64. >>>>> In case it matters, we do use a relatively old toolchain to preserve >>>>> compatibility with older distros. >>>>> >>>>> Anyone have any other experiences with preserve_most? >>>>> >>>>> -- >>>>> -- >>>>> v8-users mailing list >>>>> v8-u...@googlegroups.com >>>>> http://groups.google.com/group/v8-users >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "v8-users" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to v8-users+u...@googlegroups.com. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/v8-users/cb4f9835-165f-4e66-81e8-0de6164e0803n%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/v8-users/cb4f9835-165f-4e66-81e8-0de6164e0803n%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> >>> >>> -- >>> >>> Clemens Backes >>> >>> Software Engineer >>> >>> clem...@google.com >>> >>> Google Germany GmbH >>> >>> Erika-Mann-Straße 33 >>> >>> 80636 München >>> >>> Geschäftsführer: Paul Manicle, Liana Sebastian >>> >>> Registergericht und -nummer: Hamburg, HRB 86891 >>> >>> Sitz der Gesellschaft: Hamburg >>> >>> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten >>> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, >>> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, >>> dass die E-Mail an die falsche Person gesendet wurde. >>> >>> >>> This e-mail is confidential. If you received this communication by >>> mistake, please don't forward it to anyone else, please erase all copies >>> and attachments, and please let me know that it has gone to the wrong >>> person. >>> >>> >>> -- >> -- >> v8-users mailing list >> v8-u...@googlegroups.com >> http://groups.google.com/group/v8-users >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-users+u...@googlegroups.com. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-users/83ea2cb4-fa2e-4c52-94a6-2de1f6a32b5dn%40googlegroups.com >> >> <https://groups.google.com/d/msgid/v8-users/83ea2cb4-fa2e-4c52-94a6-2de1f6a32b5dn%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > > Clemens Backes > > Software Engineer > > clem...@google.com > > Google Germany GmbH > > Erika-Mann-Straße 33 > > 80636 München > > Geschäftsführer: Paul Manicle, Liana Sebastian > > Registergericht und -nummer: Hamburg, HRB 86891 > > Sitz der Gesellschaft: Hamburg > > Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten > haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, > löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, > dass die E-Mail an die falsche Person gesendet wurde. > > > This e-mail is confidential. If you received this communication by > mistake, please don't forward it to anyone else, please erase all copies > and attachments, and please let me know that it has gone to the wrong > person. > > > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/08f43f76-9e67-411a-9df3-9e620f9599d6n%40googlegroups.com.
