On Thu, May 21, 2020 at 6:12 PM Dirk Becker <li...@jdbecker.com> wrote: > > Hi, > > my OSX build of V8 failed with an error > ERROR at //BUILD.gn:3584:5: Unable to load > "/Volumes/Disk2/v8/third_party/zlib/BUILD.gn". > correctly so, as there is no zlib in v8/third_party . > > I commented out the matching dependency lines, introduced in > https://chromium.googlesource.com/v8/v8.git/+/858e3c7ef7bc80ea1767737853971e4e6a4633af > Along the suggestion there, I also added v8_disable_snapshot_compression = > true to my args.gn > > > After the warning > > Did you mean "v8_enable_snapshot_compression"? > I then used an v8_enable_snapshot_compression = false > > > Next is a compile error: > > [939/1601] CXX obj/v8_base_without_compiler/snapshot-compression.o > FAILED: obj/v8_base_without_compiler/snapshot-compression.o > ../../src/snapshot/snapshot-compression.cc:10:10: fatal error: > 'third_party/zlib/google/compression_utils_portable.h' file not found > > > v8_enable_snapshot_compression takes me to a define V8_SNAPSHOT_COMPRESSION > Next attempt: add several #ifdef V8_SNAPSHOT_COMPRESSION in > snapshot-compression.cc, snapshot-utils.cc and so forth. > A dead end, more and more dependencies - snapshot compression is to stay, IMO > that argument / option is toast. > > > Therefor maybe it is easier to add "third_party/zlib" . > Next problem though: Considering that reference to … > "google/compression_utils_portable.h" this is likely to be a special build. > > > As I am pretty new to V8, how should I continue? > > Thanks, > Dirk
It sounds like you did a regular `git clone`? See the instruction at [0], you need to use the fetch command from depot_tools. That will also check out dependencies, among other things. I maintain a fork[1] of V8 that uses cmake as the build tool. It lets you use the regular cmake workflow but it doesn't support every option that GN supports (yet - pull requests welcome.) [0] https://v8.dev/docs/source-code [1] https://github.com/bnoordhuis/v8-cmake -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CAHQurc8m9pG5ek6RQXVTAo9dKo9z4wRmDdro%2BZuDBfvrknJcfw%40mail.gmail.com.
