LGTM2 On Tue, Mar 24, 2020 at 7:02 AM Daniel Bratell <bratel...@gmail.com> wrote:
> Seems the automatic script failed to pick up this intent so it never ended > up on the todo list for our weekly meetings. Sorry about that. > > Anyway, looking good. In stage3 if I understand things corrrectly which > means that it has standards support, and with Mozilla's implementation > there should be no major compatibility problems. > > LGTM1 > > /Daniel > > > On 2020-03-24 06:42, Frank Tang wrote: > > ping > > On Wed, Mar 18, 2020 at 3:05 PM Mounir Lamouri <mlamo...@google.com> > wrote: > >> non-owner LGTM based on the above. 2 out of the 3 ICU bugs were pointed >> by Mozilla in their bug tracker as a reason to not launch yet. >> >> -- Mounir >> >> On Wed, 18 Mar 2020 at 14:59, Frank Tang <ft...@chromium.org> wrote: >> >>> It start from a user request and I put together this PR. Mozilla folks >>> identified some bugs in the ICU library and we just fixed them and make it >>> available recently. The PR is not merged because ECMA 402 will only merge >>> this PR if one of the engine shipt it and since I draft the PR it will >>> depend on this launch to unblock the merge. >>> >>> It was pending on the fix of the following 3 ICU bugs and they are now >>> all fixed. >>> https://unicode-org.atlassian.net/browse/ICU-20967 >>> https://unicode-org.atlassian.net/browse/ICU-20738 (assignee forget to >>> mark it but will soon) >>> https://unicode-org.atlassian.net/browse/ICU-20739 >>> >>> These fix also make our v8 implementation pass some failed test in >>> https://chromium-review.googlesource.com/c/chromium/src/+/2090002 >>> https://chromium-review.googlesource.com/c/v8/v8/+/2095394 >>> >>> On Wed, Mar 18, 2020 at 12:32 PM Mounir Lamouri <mlamo...@google.com> >>> wrote: >>> >>>> Mozilla seems to have this implemented but Nightly only so I think it >>>> would be reasonable to have their position updated from "Public Support" to >>>> "In Development". FWIW, it seems that Mozilla is keeping this in Nightly >>>> because the spec wasn't stable but it was a while ago. >>>> >>>> I also think it would be reasonable to consider Web Developers to be >>>> positive as this came from a user request >>>> <https://github.com/tc39/ecma402/issues/300> that was initially on >>>> Stack Overflow >>>> <https://stackoverflow.com/questions/53477403/how-to-format-milliseconds-with-intl-datetimeformat-api> >>>> and >>>> the same person said that solved their use case >>>> <https://github.com/tc39/ecma402/pull/347#issuecomment-494714886>. >>>> >>>> -- Mounir >>>> >>>> On Wed, 18 Mar 2020 at 11:56, Daniel Bratell <bratel...@gmail.com> >>>> wrote: >>>> >>>>> What is the current state of the spec change? It looks like the PR is >>>>> still open and not much has happened since last autumn. Preferably there >>>>> should be an agreed upon spec before something is changes, or at the very >>>>> least, the spec change and the shipping should happen close to each other. >>>>> >>>>> /Daniel >>>>> On 2020-03-18 17:54, Frank Tang wrote: >>>>> >>>>> ping >>>>> >>>>> On Fri, Mar 13, 2020 at 12:50 PM Frank Tang <ft...@chromium.org> >>>>> wrote: >>>>> >>>>>> Contact emails ft...@chromium.org,js...@chromium.org Explainer >>>>>> http://shorturl.at/adiZ4 Spec >>>>>> https://github.com/tc39/ecma402/pull/347 TAG review No TAG review >>>>>> since the TC39 and ECMA402 will cover that. Summary Enhance the >>>>>> Intl.DateTimeFormat API by adding a “ fractionalSecondDigits” option to >>>>>> control the format of fractions of a second. Link to “Intent to >>>>>> Prototype” blink-dev discussion >>>>>> https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/Intent$20to$20Implement$3A$20Add$20millisecondDigits$20option$20to$20Intl.DateTimeFormat%7Csort:date/blink-dev/WXd9nh03a1M/z7QeIMgrBgAJ >>>>>> Risks >>>>>> Interoperability and Compatibility low. *Firefox*: Public support ( >>>>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1568134) *Edge*: No >>>>>> public signals *Safari*: No public signals *Web developers*: No >>>>>> signals Ergonomics Part of the pre-existing ICU functionality w/o >>>>>> need of additional data. Activation Should be easy to use by using >>>>>> w/ pre-existing Intl.DateTimeFormat Security low >>>>>> Debuggability nothing special. Will this feature be supported on all >>>>>> six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android >>>>>> WebView)? Yes Is this feature fully tested by web-platform-tests >>>>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>>>> ? Yes Tests are added to test262 >>>>>> ./test/intl402/DateTimeFormat/constructor-options-fractionalSecondDigits-invalid.js >>>>>> ./test/intl402/DateTimeFormat/constructor-options-throwing-getters-fractionalSecondDigits.js >>>>>> ./test/intl402/DateTimeFormat/taint-Object-prototype-fractionalSecondDigits.js >>>>>> ./test/intl402/DateTimeFormat/constructor-options-order-fractionalSecondDigits.js >>>>>> ./test/intl402/DateTimeFormat/constructor-options-fractionalSecondDigits-valid.js >>>>>> ./test/intl402/DateTimeFormat/prototype/formatRangeToParts/fractionalSecondDigits.js >>>>>> ./test/intl402/DateTimeFormat/prototype/resolvedOptions/order-fractionalSecondDigits.js >>>>>> ./test/intl402/DateTimeFormat/prototype/format/fractionalSecondDigits.js >>>>>> ./test/intl402/DateTimeFormat/prototype/formatRange/fractionalSecondDigits.js >>>>>> ./test/intl402/DateTimeFormat/prototype/formatToParts/fractionalSecondDigits.js >>>>>> Tracking bug https://bugs.chromium.org/p/v8/issues/detail?id=9284 Demo >>>>>> links http://shorturl.at/adiZ4 Link to entry on the Chrome Platform >>>>>> Status https://www.chromestatus.com/feature/5704965743968256 >>>>>> This intent message was generated by Chrome Platform Status >>>>>> <https://www.chromestatus.com/>. >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL9W04fz2fEv52cv70LYKJtTm2JavowkCMEjEX6ma%3DaWaA%40mail.gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL9W04fz2fEv52cv70LYKJtTm2JavowkCMEjEX6ma%3DaWaA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/23063938-a289-cbac-a715-c994392c47ba%40gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/23063938-a289-cbac-a715-c994392c47ba%40gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f1167922-909e-4fb1-b331-cf6b42387ec3%40gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f1167922-909e-4fb1-b331-cf6b42387ec3%40gmail.com?utm_medium=email&utm_source=footer> > . > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CAOMQ%2Bw9c1r2PxhAYVFs-SJpF0uaveFvdH2j0FgpXwVPe0X-1oQ%40mail.gmail.com.
