LGTM! On Tue, Mar 12, 2019 at 5:31 PM Ben Smith <bi...@chromium.org> wrote:
> Contact emails > > bi...@chromium.org > > Spec > > https://github.com/WebAssembly/nontrapping-float-to-int-conversions > <https://github.com/WebAssembly/nontrapping-float-to-int-conversions/blob/master/proposals/nontrapping-float-to-int-conversion/Overview.md> > > Summary > > WebAssembly shipped with trapping float-to-int conversions, which are > difficult for tools to use correctly, because the behavior differs from > native machines. This proposal provides new instructions that are > non-trapping equivalents of the original conversions. > > > Interoperability and Compatibility risk > This is a phase 4 WebAssembly proposal > <https://github.com/WebAssembly/proposals>, so the compatibility risk is > low. > > Edge: Implemented <https://github.com/Microsoft/ChakraCore/pull/5014> > Firefox: Shipped > <https://bugzilla.mozilla.org/show_bug.cgi?format=default&id=1495609> > Safari: No signals > > Is this feature fully tested? > > Yes, tested in wasm cctests: > https://cs.chromium.org/chromium/src/v8/test/cctest/wasm/test-run-wasm.cc?l=3165. > Also passes spec tests: > https://github.com/WebAssembly/nontrapping-float-to-int-conversions/blob/master/test/core/conversions.wast#L252 > > > Tracking bug > > *https://crbug.com/v8/7226 <https://crbug.com/v8/7226>* > > > Entry on the feature dashboard <http://www.chromestatus.com/> > > https://www.chromestatus.com/feature/4611843511287808 > > > Requesting approval to ship? > > Yes. Note that since this is a V8/Wasm feature, this post is just an FYI > to blink-dev — no sign off from Blink API owners is required. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/72c6d3c4-2e9a-43e2-ab6a-946a2ba7ec68%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/72c6d3c4-2e9a-43e2-ab6a-946a2ba7ec68%40chromium.org?utm_medium=email&utm_source=footer> > . > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
