I don't really know how to decode where the actual error is in this chain
of error messages; maybe someone can help? Maybe I just need to turn on
ignoring the warnings?
WasmStreaming is V8_EXPORT ; USING_V8_SHARED is defined as 1
WasmStreamingImpl is V8_EXPORT
#elif USING_V8_SHARED
# define V8_EXPORT __declspec(dllimport)
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(4494):
warning C4251: 'v8::WasmStreaming::impl_': class
'std::unique_ptr<v8::WasmStreaming::WasmStreamingImpl,std::default_delete<_Ty>>'
needs to have dll-interface to be used by clients of class
'v8::WasmStreaming'
(This Line)
std::unique_ptr<WasmStreamingImpl> impl_;
1> with
1> [
1> _Ty=v8::WasmStreaming::WasmStreamingImpl
1> ]
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(4461):
note: see declaration of
'std::unique_ptr<v8::WasmStreaming::WasmStreamingImpl,std::default_delete<_Ty>>'
(This line)
WasmStreaming(std::unique_ptr<WasmStreamingImpl> impl);
1> with
1> [
1> _Ty=v8::WasmStreaming::WasmStreamingImpl
1> ]
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(4536):
warning C4251: 'v8::WasmModuleObjectBuilderStreaming::promise_': class
'v8::Persistent<v8::Promise,v8::CopyablePersistentTraits<v8::Promise>>'
needs to have dll-interface to be used by clients of class
'v8::WasmModuleObjectBuilderStreaming'
This line
Persistent<Promise, CopyablePersistentTraits<Promise>> promise_;
Persistent is NOT V8_EXPORT; nor promsie nor CopyablePersistentTraits...
they are template classes....
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(4536):
note: see declaration of
'v8::Persistent<v8::Promise,v8::CopyablePersistentTraits<v8::Promise>>'
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(4540):
warning C4251: 'v8::WasmModuleObjectBuilderStreaming::streaming_decoder_':
class 'std::shared_ptr<v8::internal::wasm::StreamingDecoder>' needs to have
dll-interface to be used by clients of class
'v8::WasmModuleObjectBuilderStreaming'
(Thsi Line)
std::shared_ptr<internal::wasm::StreamingDecoder> streaming_decoder_;
(which is in) class V8_EXPORT WasmModuleObjectBuilderStreaming final {
class StreamingDecoder;
and streamingdecoder is only an opaque class and not V8_EXPORT
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(4540):
note: see declaration of
'std::shared_ptr<v8::internal::wasm::StreamingDecoder>'
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(9224):
warning C4251:
'v8::Context::BackupIncumbentScope::backup_incumbent_context_': class
'v8::Local<v8::Context>' needs to have dll-interface to be used by clients
of class 'v8::Context::BackupIncumbentScope'
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(1310):
note: see declaration of 'v8::Local<v8::Context>'
-------
I can get these to go away removing V8_EXPORTs also....
--- class V8_EXPORT WasmModuleObjectBuilderStreaming final {
+++ class WasmModuleObjectBuilderStreaming final {
--- class V8_EXPORT WasmStreaming final {
+++ class WasmStreaming final {
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(9224):
warning C4251:
'v8::Context::BackupIncumbentScope::backup_incumbent_context_': class
'v8::Local<v8::Context>' needs to have dll-interface to be used by clients
of class 'v8::Context::BackupIncumbentScope'
1>c:\users\panther\.cmake-js\node-x64\v11.0.0\include\node\v8.h(1310):
note: see declaration of 'v8::Local<v8::Context>'
1>Done building project "sack_vfs.vcxproj".
--- class V8_EXPORT BackupIncumbentScope {
+++ class BackupIncumbentScope {
--
--
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
---
You received this message because you are subscribed to the Google Groups
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
