Indeed, that appears to have fixed it.

Thank you for the incredibly fast turn-around! Sent e-mail before leaving 
the office yesterday, arrived this morning to find problem had been 
fixed... :)

-Kenton

On Thursday, August 31, 2017 at 12:32:49 AM UTC-7, Yang Guo wrote:
>
> Does this fix solve your problem? 
> https://chromium-review.googlesource.com/c/v8/v8/+/645127
>
> On Thursday, August 31, 2017 at 3:13:12 AM UTC+2, Kenton Varda wrote:
>>
>> Hi v8-users,
>>
>> I have an application in which I use TerminateExecution() from another 
>> thread to kill off scripts that run for too long.
>>
>> Normally this works great, but when I have a v8 inspector session 
>> attached, it seems very unhappy with this situation. In particular, the 
>> process commonly aborts with:
>>
>> #
>> # Fatal error in ../../src/builtins/builtins-console.cc, line 53
>> # Check failed: !isolate->has_scheduled_exception().
>> #
>>
>> It looks like the first console.log() after the inspector connects can in 
>> fact take tens of milliseconds (at least in debug mode), frequently 
>> triggering timeouts.
>>
>> This is unfortunate as it makes it pretty easy for a malicious script to 
>> take down the process -- something that my TerminateExecution() was 
>> explicitly trying to defend against.
>>
>> Is this:
>> a) A bug in the inspector?
>> b) An unsupported use case?
>> c) Me doing something wrong in my setup?
>>
>> Thanks,
>> -Kenton
>>
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to