*Cron Job*

In Notebook.CronJob.execute, we check
note.getLastParagraph().isTerminated()? How would this work if paragraphs
in the note use different interpreters or if the interpreter uses parallel
scheduler?

  public static class CronJob implements org.quartz.Job {
    public static Notebook notebook;

    public void execute(JobExecutionContext context) throws
JobExecutionException {

      String noteId =
context.getJobDetail().getJobDataMap().getString("noteId");
      Note note = notebook.getNote(noteId);
      note.runAll();

      *while (!note.getLastParagraph().isTerminated()) {*
        try {
          Thread.sleep(1000);
        } catch (InterruptedException e) {
          logger.error(e.toString(), e);
        }
      }

*Notebook/note terminology*

In the Zeppelin UI, Notebook is a collection of notes.
Notebook
 Import note <https://zeppelin.twitter.biz/> Create new note
<https://zeppelin.twitter.biz/>

In
http://zeppelin.incubator.apache.org/docs/0.5.5-incubating/manual/notebookashomepage.html
:
Zeppelin allows you to use one of the notebooks you create as your zeppelin
Homepage.

It seems to me that the use of notebook/note is inconsistent. How should we
resolve this? Ipython/jupyter uses Notebook to mean a note in the Zeppelin
UI. Should we be consistent with that terminology? IMO, deciding the
terminology we expose to the user is more important. We can change the code
to reflect that over time.


Thanks,
Prasad

Reply via email to