Hi All,

Today I found out a bug when review Zeppelin's code: when table's result is 
bigger, sometimes the result can't show them all. Let's see code here
Paragraph.controller.js, line 1116

1.       We first set graph.height as _graph.height

2.       Then in SetTable we set table's height is paragraph.result.height

3.       Problems here: if the second height is bigger than the first one, then 
it'll be truncated, while at the same time we set graph's style is nooverflow.

Fix proposals:

1.       Before settable, we need set the graph's height as result.height

2.       Or we remove the noOverflow

Please comments.

Regards,
Dafeng

Code:
$scope.setGraphMode = function(type, emit, refresh) {
    if (emit) {
      setNewMode(type);
    } else {
      clearUnknownColsFromGraphOption();
      // set graph height
      var height = $scope.paragraph.config.graph.height;
      angular.element('#p' + $scope.paragraph.id + '_graph').height(height);

      if (!type || type === 'table') {
        setTable($scope.paragraph.result, refresh);
      }
      else {
        setD3Chart(type, $scope.paragraph.result, refresh);
      }
    }
  };

Reply via email to