So the bug is InternalNioInputBuffer not honoring maxHttpHeaderSize? Yuesong
On Jan 21, 2011, at 9:33 AM, Mark Thomas wrote: > On 21/01/2011 13:55, Yuesong Wang wrote: >> Just to confirm, it is a bug in the InputBuffer, not OutputBuffer? > > InputBuffer, yes. > > OutputBuffer not so sure. As a minimum, it should be consistent with the > other connectors. I haven't checked how they behave. > > Mark > >> >> Yuesong >> >> On Jan 21, 2011, at 6:12 AM, Mark Thomas wrote: >> >>> On 21/01/2011 00:53, Yuesong Wang wrote: >>>> Hi, >>>> >>>> Is there a reason why InternalNioInputBuffer automatically grows its >>>> buffer, effectively ignoring the maxHttpHeaderSize setting, while >>>> InternalNioOutputBuffer doesn't? I was playing around with the setting, >>>> and set it to a rather small value. While large requests seem to go >>>> through without an issue due to the automatic expansion of the buffer, the >>>> response will choke if it's over the maxHttpHeaderSize limit and an >>>> ArrayIndexOutOfBoundsException will be thrown. This lack of response size >>>> check/proper error handling in InternalNioOutputBuffer also leads me to >>>> believe that it may not be by design? >>> >>> Looks like a bug in InternalNioInputBuffer to me. Please create a >>> bugzilla entry. >>> >>> Cheers, >>> >>> Mark >>> >>>> >>>> This is tomcat 6.0.29 + NIO connector. >>>> >>>> Thanks, >>>> >>>> Yuesong >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >>>> For additional commands, e-mail: users-h...@tomcat.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: users-h...@tomcat.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: users-h...@tomcat.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org >
