Awesome dude (that you submitted the patch so quick - I've not looked at it in detail yet). Thanks!
-----Original Message----- From: Wesley Acheson [mailto:wesley.ache...@gmail.com] Sent: Monday, August 23, 2010 2:33 PM To: Tomcat Users List Subject: Re: Is there a better way to disable JSESSIONID in the URLs? https://issues.apache.org/bugzilla/show_bug.cgi?id=49811 On Sun, Aug 22, 2010 at 5:55 PM, Mark Thomas <ma...@apache.org> wrote: > On 22/08/2010 16:29, Wesley Acheson wrote: >> Sorry for bring this off list. I'll put it back on list if you think that >> appropriate. >> >> You think that the context is the correct place to put this? I thought maybe >> web.xml but I don't know if you can extend that or if its rigidly covered by >> the spec. > > web.xml is defined by the spec. You can't touch it. > >> I started to do this on the connector is that incorrect? > > The configuration needs to be per context. Look at the sessionCookieName > attribute as an example. > > For the place to actually diable it, look in the > o.a.c.connector.Response.isEncodeable() method. If you look in the TC7 > code, you'll see how the Servlet 3.0 stuff was implemented. > >> How would one submit a patch? Sorry I've never done this for any project. Do >> I just attach the changed source files to bugzilla? or do I need to do a >> diff and create a patch file. > > Patch please, in diff -u format. Bugzilla is the right place. > >> I'm on windows so I've never used patch and I >> am unsure how to create one. (unix patch file) > > I use TortoiseSVN and Eclipse on Windows. Both these tools generate > suitable patch files. > > Mark > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org . The information contained in this e-mail message is intended only for the personal and confidential use of the recipient(s) named above. This message is privileged and confidential. If the reader of this message is not the intended recipient or an agent responsible for delivering it to the intended recipient, you are hereby notified that you have received this document in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
