Thats odd... I am still getting the NPE on startup. Is it included in the binaries downloaded or do I need to rebuild myself for this patch to take effect?
On Wed, Dec 24, 2008 at 11:01 AM, Filip Hanik - Dev Lists < devli...@hanik.com> wrote: > already there > > http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?r1=719262&r2=719267 > > Filip > > > ssenecal wrote: > >> Is there any chance of getting this backported to 6.0.18? I'm hoping to >> not >> have to maintain a custom release of Tomcat in order to address the issue >> :) >> >> >> >> >> >> >> Filip Hanik - Dev Lists wrote: >> >> >>> yes, that is correct >>> >>> Alex Talis wrote: >>> >>> >>>> Filip, does this mean that this fix will be in 6.0.19 production >>>> release? >>>> Thanks >>>> >>>> >>>> >>>> ----- Original Message ---- >>>> From: Filip Hanik - Dev Lists <devli...@hanik.com> >>>> To: Tomcat Users List <users@tomcat.apache.org> >>>> Sent: Wednesday, October 29, 2008 7:15:01 AM >>>> Subject: Re: NullPointerExceptions on startup with NIO connector >>>> >>>> thanks for the report, looks it was fixed in trunk >>>> >>>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&r1=618058&r2=618059 >>>> I just forgot to backport it >>>> >>>> Filip >>>> >>>> >>>> Alex Talis wrote: >>>> >>>> >>>>> Hi, >>>>> My Tomcat 6.0.18 throws NPEs if there are incoming connections to an >>>>> NIO >>>>> connector before the connector had a chance to initialize. The >>>>> behavior >>>>> that I would expect is for Tomcat to simply refuse incoming connections >>>>> until the connector is ready. >>>>> I found a similar post on this mailing list >>>>> ( >>>>> http://mail-archives.apache.org/mod_mbox/tomcat-users/200802.mbox/%3c47a5f469.40...@apache.org%3e >>>>> ), >>>>> which links to Bug 43701 >>>>> (https://issues.apache.org/bugzilla/show_bug.cgi?id=43701). The bug >>>>> report describes the behavior that I'm seeing with 6.0.18, but says >>>>> that >>>>> it's fixed in 6.0.15 onwards. Is it back? Below is my config and how >>>>> I >>>>> reproduce the problem. Exceptions are the same as in the bug report >>>>> above, but with different line numbers. Thanks in advance for your >>>>> help. >>>>> Tomcat version info (from running version.bat) >>>>> ----------------------------------------------- >>>>> Server version: Apache Tomcat/6.0.18 >>>>> Server built: Jul 22 2008 02:00:36 >>>>> Server number: 6.0.18.0 >>>>> OS Name: Windows 2003 >>>>> OS Version: 5.2 >>>>> Architecture: x86 >>>>> JVM Version: 1.5.0_05-b05 >>>>> JVM Vendor: Sun Microsystems Inc. >>>>> Steps to reproduce >>>>> -------------------- >>>>> 1. Add an NIO connector to server.xml, like this >>>>> <Connector port="8081" >>>>> protocol="org.apache.coyote.http11.Http11NioProtocol" maxThreads="150" >>>>> connectionTimeout="20000" acceptorThreadCount="1" >>>>> redirectPort="8444" socket.directBuffer="false"/> >>>>> 2. Open browser and point it to http://localhost:8081/. It's easier >>>>> to >>>>> reproduce with Firefox for some reason. >>>>> 3. Start Tomcat by double-clicking startup.bat >>>>> 4. As Tomcat is starting, keep refreshing the browser by quickly >>>>> clicking the refresh button as fast as you can. It may not work the >>>>> first time. >>>>> >>>>> You should see some NullPointerExceptions in Tomcat log, like this: >>>>> Oct 28, 2008 11:10:22 AM org.apache.tomcat.util.net.NioEndpoint >>>>> setSocketOptions >>>>> SEVERE: >>>>> java.lang.NullPointerException >>>>> at >>>>> >>>>> org.apache.tomcat.util.net.NioEndpoint.setSocketOptions(NioEndpoint.java:1011) >>>>> at >>>>> >>>>> org.apache.tomcat.util.net.NioEndpoint$Acceptor.run(NioEndpoint.java:1204) >>>>> at java.lang.Thread.run(Unknown Source) >>>>> Oct 28, 2008 11:10:22 AM org.apache.tomcat.util.net.NioEndpoint >>>>> setSocketOptions >>>>> SEVERE: >>>>> java.lang.NullPointerException >>>>> at >>>>> >>>>> org.apache.tomcat.util.net.NioEndpoint.setSocketOptions(NioEndpoint.java:1011) >>>>> at >>>>> >>>>> org.apache.tomcat.util.net.NioEndpoint$Acceptor.run(NioEndpoint.java:1204) >>>>> at java.lang.Thread.run(Unknown Source) >>>>> Oct 28, 2008 11:10:22 AM org.apache.coyote.http11.Http11NioProtocol >>>>> start >>>>> INFO: Starting Coyote HTTP/1.1 on http-8080 >>>>> Oct 28, 2008 11:10:22 AM org.apache.catalina.startup.Catalina start >>>>> INFO: Server startup in 831 ms >>>>> >>>>> >>>>> >>>> --------------------------------------------------------------------- >>>> To start a new topic, e-mail: users@tomcat.apache.org >>>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >>>> For additional commands, e-mail: users-h...@tomcat.apache.org >>>> >>>> >>> --------------------------------------------------------------------- >>> To start a new topic, e-mail: users@tomcat.apache.org >>> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: users-h...@tomcat.apache.org >>> >>> >>> >>> >>> >> >> >> > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > >