Dan Armbrust wrote:
The only reasons he was given was that it was smaller (and we care
why?) and that it _might_ prevent a version conflict issue.
Size - don't care that much but as a side effect it isn't going to cause
any harm. Version conflicts, however, are a big issue. Many web apps
include the DBCP jars and deploying such an app in the servlet class loader
environment where a different version of DBCP exists is a nightmare. Whilst
you can work around one app, when you have multiple apps each with a
different DBCP version you rapidly run out of options.
Maybe you should refactor log4j and commons logging next. Never know
when you might have an issue there.... ;)
Where we have issues we have / we will.
If there are any other legitimate reasons - such as - you needed to
fix some bugs in the code that weren't being addressed in dbcp, then
you should just put the code in your source control system.
If this was the problem, the right way to fix it would be to go and help
out DBCP and fix the bugs in the source. This is exactly what happened just
before the latest round of releases to fix
http://issues.apache.org/bugzilla/show_bug.cgi?id=43552 which was caused by
a commons-pool bug.
As for getting the source you need there are plenty of simple options. Had
you sent a polite request to the list for help, you would have had the
source by now.
Yes, but that wouldn't have helped the fact that I had already spent a
lot of valuable time trying to trace the history of this mess. You
have to admit, its really not very obvious.
It isn't as obvious as the source just being there but as you discovered it
has been discussed on the lists and the build script is pretty clear.
Plus, I already had my
solution, I stopped using the tomcat implementation. Looks like most
of the 3rd party package maintainers had the same conclusion. They
dropped the package.
My recollection is that they didn't drop it but got it from the binary
package rather than reproduce the build process.
It seems that at a minimum, you should at least include the refactored
source code in the source download. But I don't care one way or
another at this point, I now know to avoid this package in order to
make my life easier.
If you care about this you can always open a bugzilla entry for an
enhancement and propose a patch.
Mark
---------------------------------------------------------------------
To start a new topic, e-mail: users@tomcat.apache.org
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
