Hi Chris,
Am 27.05.2022 um 01:49 schrieb Christopher Schultz:
On 5/26/22 17:25, Rainer Jung wrote:
Am 26.05.2022 um 21:49 schrieb Christopher Schultz:
Would you prefer to use mod_unique_id + unique-id-logging in mod_jk over
just adding more request-level information to the mod_jk.log? I'm kind
of okay either way, but for my current purposes it seems more convenient
to have all relevant information in a single place (the mod_jk.log file).
I understand, but more useful info might pile up (URI, client IP), so I
prefer having a working correlation ID to the other major sources of
info, Apache access log and Apache error log. Also: the current idea of
mod_jk when a request starts is not exactly when it started in Apache,
but when the JK service method started. So we would also need to add the
web server start time.
For now I used the request id and switched a lot (!) of log calls to
using the new jk_request_log instead of jk_log. So you get the id in the
next release for many of the lines mod_jk is able to log in a request
context. Some very low level log lines will not have access to the
request id, but on ase of error they should always be accompanied by a
higher level logging of the error including the request id.
We'll see how it goes. Feel free to try it, I committed everything to
the git repos.
I'm okay adding either or both of these "features" to the JK portion of
the code. If we are considering "enhancing" this kind of logging in the
JK portion, I would recommend that we add request_start_time to the
jk_ws_service; I don't see a good way to determine the nature of the
host web server from within the JK code and it's better-done from the
outside-in rather than the inside-out.
Unrelated: I believe the segfaults I'm seeing have to do with me simply
updating the .so file on the disk before restarting the httpd process.
As soon as I copy the .so file over the existing module binary, I start
getting a string of segfaults in the log file. When I don't try to
"hot-update" the module binary, I don't see any of that happening. (I
also don't see any possible segfaults in my code at this point, eitaher.)
I have httpd set up to dump cores but I think my file permissions are
wrong so I'm not actually getting anything in there (yet).
Best regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org
