Thomas, On 3/23/22 10:13, Thomas Hoffmann (Speed4Trade GmbH) wrote:
Hello,I got some warnings logged from http2 protocol and the logged values seem to be wrong. If an unknown http2 settings is received, it logs the key and the value to the logfile: /org/apache/coyote/http2/ConnectionSettingsBase.java, line 90: case UNKNOWN: // Unrecognised. Ignore it. log.warn(sm.getString("connectionSettings.unknown", connectionId, setting, Long.toString(value))); return; The value of the settings-variable was unfortunately converted before to Integer.MAX_VALUE within the settings.java enum Setting { HEADER_TABLE_SIZE(1), ENABLE_PUSH(2), MAX_CONCURRENT_STREAMS(3), INITIAL_WINDOW_SIZE(4), MAX_FRAME_SIZE(5), MAX_HEADER_LIST_SIZE(6), UNKNOWN(Integer.MAX_VALUE); Thus, the logfile doesn’t contain the received, unknown settings-key but MAX_VALUE instead. Is it possible to log the real settings key, which was received by the server? Maybe the logging can be moved to the Setting.java instead or the real key value would have to be transferred to the function which logs(?)
I think the existing log can probably just be fixed, no? Want to take a stab at writing a PR for this?
-chris --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
