Sorry for not mentioning that before, Felix. I’ve seen this bug under Mac & Windows Java versions. We only support Java 1.8, at the moment.
Mac: openjdk version "1.8.0_222" OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10) OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode) Windows: openjdk version "1.8.0_192" OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_192-b12) OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.192-b12, mixed mode) We’ve also reproduced this issue with multiple Tomcat versions, including 7, 8 & 9. If we use Oracle Java, the issue is fixed & doesn’t happen. The bug is very subtle since the JSP does compile, but the data passed to our tag is a String instead of a Date object. Thanks, Jeff LoBello Lead Software Engineer Cerner | www.cerner.com<http://www.cerner.com/> From: Felix Schumacher <felix.schumac...@internetallee.de> Reply-To: Tomcat Users List <users@tomcat.apache.org> Date: Saturday, October 26, 2019 at 4:18 PM To: Tomcat Users List <users@tomcat.apache.org> Subject: Re: JSP custom tag operating different when adoptOpenJDK is used vs Oracle (cross post from tomcat-taglibs-user) Am 25. Oktober 2019 19:33:19 MESZ schrieb "LoBello,Jeff" <jeff.lobe...@cerner.com.INVALID<mailto:jeff.lobe...@cerner.com.INVALID>>: We have a custom tag, FormatDateTag extends org.apache.taglibs.standard.tag.common.fmt.FormatDateSupport. It’s been working ok for a number of years under tomcat & Oracle JVM. Now, we are moving to adoptOpenJDK & we are seeing some differences in how tomcat generation of JSP to Java classes happens when tomcat is doing the EL evaluation. Here is an example JSP which shows the issue… Which Java versions have you used exactly? What os was this? Which tomcat version have you used? Are there any other differences in the setup? Felix <%@ page language="java" contentType="text/html" isELIgnored="false" %> <%@ page import="java.util.Date" %> <%@ taglib uri="/WEB-INF/tld/suitags.tld" prefix="sui" %> <% Date chdt = new Date(); request.setAttribute("chdt", chdt); %> <sui:formatDate value="${chdt}" type="date" dateStyle="shortfull" /> Looking at the compiled JSP source code under Oracle JVM, we see this… // /tagUnitTests/sui/formatDate/testCaliHDateTime1.jsp(20,0) name = value type = java.lang.Object reqTime = true required = true fragment = false deferredValue = false expectedTypeName = null deferredMethod = false methodSignature = null _jspx_th_sui_005fformatDate_005f0.setValue((java.lang.Object) org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate("${chdt}", java.lang.Object.class, (javax.servlet.jsp.PageContext)_jspx_page_context, null)); The same source compiled using AdoptOpenJDK, we see this… // /tagUnitTests/sui/formatDate/ testCaliHDateTime1.jsp(20,0) name = value type = java.lang.Object reqTime = true required = true fragment = false deferredValue = false expectedTypeName = null deferredMethod = false methodSignature = null _jspx_th_sui_005fformatDate_005f0.setValue((java.lang.String) org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate("${chdt}", java.lang.String.class, (javax.servlet.jsp.PageContext)_jspx_page_context, null)); As a workaround, we’re adding calls to <fmt:parseDate> to convert the String back to a Date. Has anyone run into this? Any ideas we can try to find the root cause? Thanks, Jeff LoBello Lead Software Engineer Cerner | www.cerner.com<http://www.cerner.com/> CONFIDENTIALITY NOTICE This message and any included attachments are from Cerner Corporation and are intended only for the addressee. The information contained in this message is confidential and may constitute inside or non-public information under international, federal, or state securities laws. Unauthorized forwarding, printing, copying, distribution, or use of such information is strictly prohibited and may be unlawful. If you are not the addressee, please promptly delete this message and notify the sender of the delivery error by e-mail or you may call Cerner's corporate offices in Kansas City, Missouri, U.S.A at (+1) (816)221-1024. --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org<mailto:users-unsubscr...@tomcat.apache.org> For additional commands, e-mail: users-h...@tomcat.apache.org<mailto:users-h...@tomcat.apache.org> CONFIDENTIALITY NOTICE This message and any included attachments are from Cerner Corporation and are intended only for the addressee. The information contained in this message is confidential and may constitute inside or non-public information under international, federal, or state securities laws. Unauthorized forwarding, printing, copying, distribution, or use of such information is strictly prohibited and may be unlawful. If you are not the addressee, please promptly delete this message and notify the sender of the delivery error by e-mail or you may call Cerner's corporate offices in Kansas City, Missouri, U.S.A at (+1) (816)221-1024.
