-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Mark,

On 5/11/18 2:46 PM, Mark Thomas wrote:
> On 08/05/18 17:59, Christopher Schultz wrote: <snip/>
> 
>> This bites enough people that it may be worth correcting, or at
>> least changing the behavior when it happens.
>> 
>> AJP already encodes the packet-size in the header of each packet.
>> Why not simply compare that to the MaxPacketSize on the Tomcat
>> side and issue a useful error message instead of whatever is
>> currently happening?
> 
> Done.

Excellent.

> Most likely there would have been an error message logged anyway,
> but that would have been about the next bytes being an invalid
> packet header. Now there is an explicit error logged for the
> message being too big.

I think this will really help in the small number of cases where it
comes up. Most people use the default size or successfully set both
ends of the connection to the max size (65535), but debugging a
mismatch san be a bear.

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlr2B0QACgkQHPApP6U8
pFhZURAAxCVvciCTiweb3OTnLg3t/jXeV21nczVc4dspu9z6uRe9NXEN/y88pacv
zFYSiqBrFPWXOM6xHsfVFYllhL3DcjjGP+fWiinPs5OWn+C967EtifwP5IN9c6DG
kV8vPBR0VeAbHJ9ZGETZSOQpr38g8pqnEArWX1kzB4uHx3bxMamWM3vls5Oh07m0
QaMwg4SwFCC0UkVPgYoEXO33/NyaeP5D5+n40lUl7c+HGbx8kWTWh28FnAAEVGfx
xPnvdcwlt1JyNU+wSec1yaQdCvULLyBjGIBcr++K/SiJucpLIR48z/oBfkSimkp+
GtbBU2HoemBiA6ntYChHw8D2Bfg/pm6OK3wObuI+eGInXOiD77qEuqMvGXk8Edx6
BmM7mhrxBSiRbSShgfvmd4bsiWfnXo3lcB5C6buGeqPhgrEyXRRiXRMKZp9fQg++
/NxvkU2Rg0M5NzEZC1DpbMCEzM8vkoTPmu5ztvrA1/8pmgCGSJb09kBChl6sdajx
4xxhFQzPNalePTGpPPf9uJWKua1WQMHdloKpROobZYRyaiBtRSoq7VSTjMT4rPvZ
g5WxKEnIb2cfTyUFzZOfPoNrelM5PoC/3im/8TzxhaRKVXXJ2GX419g6ewBLYCUD
o/fbWQlQJfLCH5NWR6uVJXRi8ARbcjraIjM3VVO2c7HIOYRmMqM=
=UD5P
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org

Reply via email to