On 07/03/18 12:02, Sen, Anurag wrote: > > >> -----Original Message----- >> From: Mark Thomas [mailto:ma...@apache.org] >> Sent: 07 March 2018 17:17 >> To: users@tomcat.apache.org >> Subject: Re: [Tomcat Custom Connector]Private Fields in NIOEndpoint class >> >> On 07/03/2018 11:05, Sen, Anurag wrote: >>> Agreed, that Endpoint is protocol agnostic. My query was more in concern >> with the endpoint implementations being so encapsulated, that it leaves very >> little scope to extend tomcat endpoints(without actually copy-pasting the >> code >> into the custom endpoint). >>> >>> I had a look at ALPN usage and I don't see how BEEP using ALPN upgrade can >> function. Will continue digging. >> >> If some refactoring and/or making methods protected and/or adding acessors >> would help we'd certainly be open to that. >> >> The original aim was to reduce the 'public' API to give us greater freedom to >> refactor. If we know where folks need to extend we can make sure those >> extension points work as intended. >> >> Mark >> > > Thanks! It will help us tremendously (and other custom connector > implementations), if the 'public' API is a bit relaxed, as prior to Tomcat > 7.0. I can certainly contribute a patch, if you can point me to how to.
Great. https://github.com/apache/tomcat/blob/trunk/CONTRIBUTING.md Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
