On 24/04/17 15:57, Tobias Brennecke wrote: > On 24/04/17 14:24, Mark Thomas wrote: > >> >>> That looks like a bug to me. >>> >>> We need to go through and check all the places URLs are being encoding >>> and check it is being done correctly. >> This is now complete for 9.0.x, 8.5.x, 8.0.x and 7.0.x. >> >>> I am concerned that fixing this may break apps that rely on the broken >>> behaviour. We might need to provide some configuration to work around this. >> I haven't provided any configuration options yet. Any issues will be >> considered on a case by case basis. >> >> Mark > > Hi Mark, > > thanks a lot for looking into this! I already saw you added this to the > (unreleased) changelog. > Just let me know if you could use some help, if there's still anything > to do? > Maybe with a patch or by improving unit tests and documentation?
Hi Tobias, The Tomcat community always welcomes additional help. Additional unit tests are always would be welcome. Generally, a new unit test should aim to improve (however slightly) the code code coverage [1]. In terms of where to start looking, URLEncoder is pretty well covered. It looks like it is the error cases that need testing. In terms of the other functionality, the test I had to fix after applying this patch [2] might give you some ideas. If there are areas of documentation you think could be improved then patches for those changes would also be very welcome. Equally, please take the above as suggestions rather than as an instruction. Anywhere you'd like to start contributing would be great. Kind regards, Mark [1] https://ci.apache.org/projects/tomcat/tomcat9/coverage/ [2] http://svn.apache.org/viewvc?rev=1792468&view=rev > > > > Many regards, > > Tobias > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
