Hi Mark,
On 10/20/2016 1:19 PM, Mark Thomas wrote:
Can I submit a patch for that?
Sure. Got for it.
I'm not very familiar with SVN (hopefully Apache will move to GIT soon),
so I wasn't sure where to submit the patch.
The Apache Contributors Guide suggests the bug tracking platform. Should
I create a ticket in Bugzilla and add the patch there?
I also attached the patch file here for convenience.
Thank you,
Igal
Index: bin/service.bat
===================================================================
--- bin/service.bat (revision 1765885)
+++ bin/service.bat (working copy)
@@ -142,6 +142,10 @@
set
"CLASSPATH=%CATALINA_HOME%\bin\bootstrap.jar;%CATALINA_BASE%\bin\tomcat-juli.jar"
if not "%CATALINA_HOME%" == "%CATALINA_BASE%" set
"CLASSPATH=%CLASSPATH%;%CATALINA_HOME%\bin\tomcat-juli.jar"
+if "%SERVICE_STARTUP_MODE%" == "" set SERVICE_STARTUP_MODE=manual
+if "%JvmMs%" == "" set JvmMs=128
+if "%JvmMx%" == "" set JvmMx=256
+
"%EXECUTABLE%" //IS//%SERVICE_NAME% ^
--Description "Apache Tomcat @VERSION@ Server - http://tomcat.apache.org/";
^
--DisplayName "%DISPLAYNAME%" ^
@@ -159,9 +163,11 @@
--StopClass org.apache.catalina.startup.Bootstrap ^
--StartParams start ^
--StopParams stop ^
- --JvmOptions
"-Dcatalina.home=%CATALINA_HOME%;-Dcatalina.base=%CATALINA_BASE%;-Djava.io.tmpdir=%CATALINA_BASE%\temp;-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager;-Djava.util.logging.config.file=%CATALINA_BASE%\conf\logging.properties"
^
- --JvmMs 128 ^
- --JvmMx 256
+ --JvmOptions
"-Dcatalina.home=%CATALINA_HOME%;-Dcatalina.base=%CATALINA_BASE%;-Djava.io.tmpdir=%CATALINA_BASE%\temp;-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager;-Djava.util.logging.config.file=%CATALINA_BASE%\conf\logging.properties;%JvmArgs%"
^
+ --Startup "%SERVICE_STARTUP_MODE%" ^
+ --JvmMs "%JvmMs%" ^
+ --JvmMx "%JvmMx%"
+
if not errorlevel 1 goto installed
echo Failed installing '%SERVICE_NAME%' service
goto end
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org
