-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Steve,
On 9/6/16 8:56 PM, Mekkelsen Madden, Steve wrote: > -----Original Message----- From: James H. H. Lampert > [mailto:jam...@touchtonecorp.com] Sent: Tuesday, September 06, 2016 > 6:59 PM To: Tomcat Users List <users@tomcat.apache.org> Subject: > Re: AT WITS END regarding JVM arguments > > On 9/6/16, 8:05 AM, Christopher Schultz wrote: > >> It's worth noting that, when creating the service from the >> command-line, the service.bat script will use the current >> environment to configure the service. That means that >> CATALINA_HOME and CATALINA_BASE are all used to configure the >> service. >> >> Unfortunately, CATALINA_OPTS is not used. I'll have a look to see >> how tough it would be to add CATALINA_OPTS-handling to >> service.bat... it seems like it would be nice to do that, and >> fairly easy. > > I wouldn't sweat that part. I still think that the best way to deal > with the situation is to put a prominent warning in the preamble > comments of the relevant configuration files, explaining that the > configuration files are ignored when Tomcat is run as a Windows > Service, including links to relevant online documentation for the > configuration utility. > > I would say that it's valid to assume that somebody *installing* > Tomcat on a Windows box, to be run as a service, might reasonably > be expected to know about how it works, and how to configure it, > whereas somebody like me, accustomed to other platforms, and who > has never had a reason to study the Windows service part of the > Tomcat docs, would have no reason to know about it. > > -- JHHL > > I do not agree with that statement. It is rarely if ever, safe to > assume anything. For years, that IS what I've done to create the > Windows Service. Why else would you have a service.bat file if it > didn't create the service for you?? In prior releases (8.0.* and > older), I have never had a problem with using this to create the > Windows Tomcat Service. JVM Arguments get added, memory settings, > arguments etc. Never a problem. > > If it is not working in 8.5 series, I'd say that's a regression > issue to be fixed. Adding a preamble doesn't mean someone won't > continue to create services this way. If the service.bat won't do > it correctly there are two choices - fix it so it does create the > service properly or remove it from the build and make people use > the one that does do it correctly. An ounce of prevention saves a > lot of headaches down the road for everyone. Let's go to the root > of the issue, not apply a band aid to it. There's no regression. James was just saying that it took him a long time to figure out why hos changes weren't working. Documentation tweaking is worthwhile. James, would you care to provide a (simple) patch? You'll get your name in the changelog :) - -chris -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJX0YT/AAoJEBzwKT+lPKRYbn4QAKDHnxYq25cupT1/+Pvr9GbB btsbA+nXNx45PSjAdNLOBjIQ0TYyFe4sdlnSZiPeSoHPxD88W1pXEyNurdydC+/8 Fw/i/LCT/th56TffDqRdlxgQwvx3Hs7WgowSggqJWqrSr0MgNxeAH8HChh/s8c5C Ig8dH7fhqd2cVboVmlFGz+2XBOq0lt4Vajlxh1Sc2dV0TJHIbEEO9tiClxNV1o3V 6A7ZnKNfBBDM5XE7ePjYBlCaDiif/+jdsFx2JNFTENSGQrOTRptLlXXSfQc1bidU iBt0hQpMNughuKm3BZCpcbq+TkFriy+4ZxExGsosjK+sKzsyUIVG4L7fZnW0NJWX 1iD5KriZ48qx7HUkDYN1TxBT4vu4xRcHsX16ZR4vNBlGFXiel2wnZeC5Yvj/Gcli Tbds6CpgklxhfP6JtVXeuSlmfK7kQmEVlprTLfP2MyeDGbFkNM+AT7egsX07rsGa U06w7EZ89k5HoX9wMvrS5FpwhDiwvDR9yFrrpBE3ZdsBfFN6YLxCidmeQ79Ek6PQ cbhAQxvCKTGZo4qRUzacdgV6w/hUilQ+Urv9X6Fn4OZs5Kr1A6fbofHjY8FJlN6i Va5Kt09/QAB3tFqcc0lZsXni4utKNxR74syRxsj3zmckh4SZdXh4RKxxNpJbHZzU eeI1OVuauGJRO4vR+ruE =H1Cy -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
