On 27/02/2014 14:29, Johan Compagner wrote: > On 27 February 2014 15:16, Mark Thomas <ma...@apache.org> wrote: > >> Sorry, I got confused about what changed between which 7.0.x and 8.0.x >> versions. There was a lot of rapid changes over a short period of time >> as folks reported different issues. >> >> The solution you propose is not acceptable as it causes other problems: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=56045 >> >> The solution in 7.0.x (and released in 7.0.51) was to place all of the >> necessary schema in the Servlet JAR. >> >>> i need to patch this before it works for me (because we are running >> tomcat >>> also in a OSGI enviroment and then >>> jsp-api and servlet-api jars are not the same classloader >>> >>> They are bundles of there own. So you can't load jsp related xml files >>> (from the jsp-api jar) through the ServletContext.class >>> the id == null for me >> >> What code path is trying to load JSP XML files from jsp-api.jar? Tomcat >> should be loading them all from servlet-api.jar >> > > ahh > > the servlet-api.jar that now ships with tomcat has now also a copy of the > same resources the jsp-api.jar also has > So the > if (id == null) { > id = JspContext.class.getResource("resources/" + url); > } > > should never be hit anymore in a real tomcat install > > The problem why i still have it is because i use a servlet-api bundle osgi > bundle not coming from tomcat. > (i would need to patch the manifest file to be able to use it as a real > osgi bundle in eclipse) > > But i understand now that the fix was differently applied and why i still > had problems with it. > > (tomcat kind of changed the "standard", "jsr" api lib ;) )
I'd argue that a servlet-api.jar that doesn't include the JSP XML schemas is broken (which is why we changed it) since: - Servlet has no declared dependency on JSP - You can't validate XML documents against the schemas used by the Servlet spec without the JSP schemas Therefore the JSP schemas have to be included in the servlet-api.jar Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
