On 12/09/2013 11:49, Xavier Dury wrote: > Hi, > > I implemented a simple ExpressionFactory @ > https://github.com/kalgon/expression-factory. > > I would love to see this ExpressionFactory next to > org.apache.naming.factory.BeanFactory in tomcat.
No objections in principle. Haven't looked at the new code in detail. A few initial observations: - I'm assuming this is a contribution as per section 5 of the Apache License, version 2.0 - There is no documentation - Tomcat code standards use 4 spaces for indents, not tabs - Some @Override markers look to be missing Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
