Hi,

why does the ErrorReportValve trigger the report on this condition only?

 if ((statusCode < 400) || (response.getContentCount() > 0))
            return;

So, even if I do a reponse.setStatus(404), this valve is executed. According to 
the Javadoc: if setStatus is invoked [1], the response should be left untouched 
in constrast to the sendErroor method. Especially this sentence makes it clear 
"If this method is used to set an error code, then the container's error page 
mechanism will not be triggered. "

Shouldn't that include a response.isError() check?

[1] 
http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletResponse.html#setStatus%28int%29

Thanks,

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
For additional commands, e-mail: users-h...@tomcat.apache.org

Reply via email to