On Mon, Oct 27, 2014 at 8:51 AM, George Christman <gchrist...@cardaddy.com>
wrote:
> Sorry Kalle, it's still not entirely clear to me what I should be doing.
> Your saying LoginContextService is internal? Is there another way to access
> getXxxURL then? Also, how do we handle redirectedToSavedRequest now? At
>
You handle it the same way as before. LoginContextService has been internal
since the beginning and it's there because I know for some use cases, you
may need the flexibility to override it but for the simple use cases,
contributing suitable login, success etc. urls would be enough - in which
case you don't have to change the behavior of LoginContextService directly.
> some point when you get everything ironed out it might be helpful to
> present this as a little snippet of code in the guide. I'm finding myself
> having to sift through the github code in order to get a handle on it.
>
I'll document the services once they become public (i.e. non-internal). In
the meantime, nothing wrong sifting through the github code. I did a simple
operation rename on internal service and you should not read it as anything
more than that.
Kalle
> On Mon, Oct 27, 2014 at 11:24 AM, Kalle Korhonen <
> kalle.o.korho...@gmail.com
> > wrote:
>
> > On Mon, Oct 27, 2014 at 7:30 AM, George Christman <
> gchrist...@cardaddy.com
> > >
> > wrote:
> >
> > > That's great Kalle. Thanks
> > >
> > > Question, I see you deprecated some methods, but I'm not seeing any
> > > documentation on the new usage. I'm using the following code and I'm
> > seeing
> > > getSuccessPage() and getLoginPage() has been deprecated. I think I read
> > >
> >
> > LoginContextService is internal because that part of the API is still in
> > flux. The getXxxURL() operations will replace getXxxPage() operations
> > (because they return a string, not a page). So far, they do the same
> exact
> > thing.
> >
> > Kalle
> >
> >
> >
> > > something about about getLoginPage() being replaced by getLoginURL(),
> but
> > > I'm not completely clear on this change. I checked github and see your
> > > still using getLoginPage() in your login page, so I'm at a loss. Also,
> > what
> > > do we need to do to get the redirectToSavedRequest working now? Thanks
> > > Kalle
> > >
> > > String requestUri = loginContextService.getSuccessPage();
> > >
> > > if (!requestUri.startsWith("/")) {
> > > requestUri = "/" + requestUri;
> > > }
> > >
> > > loginContextService.redirectToSavedRequest(requestUri);
> > >
> > > return null;
> > >
> > > On Fri, Oct 24, 2014 at 9:28 PM, Chris Mylonas <ch...@opencsta.org>
> > wrote:
> > >
> > > > Toot toot!
> > > >
> > >
> > >
> > >
> > > --
> > > George Christman
> > > www.CarDaddy.com
> > > P.O. Box 735
> > > Johnstown, New York
> > >
> >
>
>
>
> --
> George Christman
> www.CarDaddy.com
> P.O. Box 735
> Johnstown, New York
>
