On Wed, Aug 28, 2013 at 6:58 PM, Dmitry Gusev <dmitry.gu...@gmail.com>wrote:
> Also no CSS files were loaded to the page, though I'm seeing bootstrap CSS > classes applied to HTML elements and there are many *.js files added to the > page, including some bootstrap.js. > > Should I add those manually? > > Sorry, found this in the release notes: 185<https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=54_RELEASE_NOTES.txt;h=faad9147d6fb543141ef066d9000a9e510139d2f;hb=HEAD#l185>The Bootstrap CSS is now only present if the `core` JavaScript stack is imported. You may need to change your application's 186<https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=54_RELEASE_NOTES.txt;h=faad9147d6fb543141ef066d9000a9e510139d2f;hb=HEAD#l186>layout component to do so explicitly, by adding `@Import(stack="core")` to the class. > Here's the source: > > <html xmlns:t="http://tapestry.apache.org/schema/tapestry_5_3.xsd" xmlns:p > ="tapestry:parameter"> > > <head></head> > > <body> > > <t:beaneditform object="task" /> > > </body> > > </html> > > public class Index > > { > > @Property > > private Task task; > > } > > public class Task > > { > > @Validate("required") > > private String title; > > > > public String getTitle() > > { > > return title; > > } > > public void setTitle(String title) > > { > > this.title = title; > > } > > } > > > > > > On Wed, Aug 28, 2013 at 6:40 PM, Dmitry Gusev <dmitry.gu...@gmail.com>wrote: > >> I've created test app using this release and found these messages in a >> console, which probably should be fixed: >> >> 18:30:23.902 [http-bio-8080-exec-1] ERROR >> o.a.t.m.AssetsModule.AssetSource - Packaging of classpath assets has >> changed in release 5.4; Assets should no longer be on the main classpath, >> but should be moved to 'META-INF/assets/' or a sub-folder. Future releases >> of Tapestry may no longer support assets on the main classpath. >> 18:30:23.902 [http-bio-8080-exec-1] ERROR >> o.a.t.m.AssetsModule.AssetSource - Classpath asset >> '/META-INF/assets/tapestry5/datepicker_106/js/datepicker.js' should be >> moved to folder >> '/META-INF/assets/core/META-INF/assets/tapestry5/datepicker_106/js/'. >> 18:30:23.907 [http-bio-8080-exec-1] ERROR >> o.a.t.m.AssetsModule.AssetSource - Classpath asset >> '/META-INF/assets/tapestry5/datepicker_106/css/datepicker.css' should be >> moved to folder >> '/META-INF/assets/core/META-INF/assets/tapestry5/datepicker_106/css/'. >> >> The page contains <t:beaneditform /> editing simple object with one field >> of type String. >> >> >> On Wed, Aug 28, 2013 at 3:56 PM, Peter Hvass <p.hv...@albourne.com>wrote: >> >>> It's obviously not super desirable but I found the relevant Github issue >>> (https://github.com/SomMeri/less4j/issues/160) and stepped through, >>> fixed the few small issues >>> that were causing infinite loops and less compilation errors just >>> temporarily for the time being so that we can fix up the class name usage >>> in our projects. >>> >>> >>> Just watch out for things like; >>> .something { >>> .something(); >>> } (infinite loop; so just copy paste the contents of .something() from >>> either mixins.less or utilities.less) >>> >>> >>> And mixin declarations whose variables end in a ; >>> .somemixin(@someVar;)... >>> (Just remove the trailing ;) >>> >>> >>> We're now done changing bootstrap 2 class names to bootstrap 3 ones and >>> the like. It wasn't too painful. >>> >>> >>> It strikes me that there's no really good source or best practice for >>> maintaining customized bootstrap less. >>> >>> >>> Does anyone here have any ideas? >>> >>> >>> For the time being we maintain a variables.less and bootstrap.less for >>> each project. So we have variables-project.less, bootstrap-project.less. >>> variables-project containing overridden variables from the vanilla >>> variables.less and bootstrap-project.less including variables-project.less >>> and allowing us to >>> further shim in modifications to other bits of bootstrap. >>> >>> We'd ideally like to chop up and load only the necessary less files >>> depending on what's in use on the page. For instance if we're only using the >>> navbar, include a less file importing only the dependent less files for >>> the navbar. >>> >>> >>> Getting a bit OCD about all this. o_O >>> >>> >>> Thanks again Howard! Looking forward to the first beta! >>> >>> >>> ----- Original Message ----- >>> >>> From: "Howard Lewis Ship" <hls...@gmail.com> >>> To: "Tapestry users" <users@tapestry.apache.org> >>> Sent: Wednesday, August 28, 2013 2:41:52 PM >>> Subject: Re: Tapestry 5.4-alpha-15 >>> >>> There's outstanding bugs in Less4J that they are in the process of >>> correcting, to support compilation of Bootstrap 3. >>> >>> >>> On Wed, Aug 28, 2013 at 12:41 PM, Howard Lewis Ship <hls...@gmail.com >>> >wrote: >>> >>> > I'm interested to see if the bootstrap 3 .less files can be compiled >>> with >>> > Less4J (or with the primary JavaScript implementation of Less, for that >>> > matter). >>> > >>> > >>> > On Wed, Aug 28, 2013 at 8:58 AM, Peter Hvass <p.hv...@albourne.com> >>> wrote: >>> > >>> >> Many thanks for all the hard work. We're especially pleased to see the >>> >> inclusion of bootstrap js as individual component files! >>> >> >>> >> >>> >> Currently plugging in the bootstrap 3 less files so we can start >>> renaming >>> >> the classes in our project. :) >>> >> >>> >> >>> >> Thanks again! >>> >> >>> >> >>> >> ----- Original Message ----- >>> >> >>> >> From: "Howard Lewis Ship" <hls...@gmail.com> >>> >> To: "Tapestry users" <users@tapestry.apache.org> >>> >> Sent: Wednesday, August 28, 2013 10:56:02 AM >>> >> Subject: Re: Tapestry 5.4-alpha-15 >>> >> >>> >> Yes, I've been keeping pretty detailed notes: >>> >> >>> >> >>> >> >>> https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=54_RELEASE_NOTES.txt;h=faad9147d6fb543141ef066d9000a9e510139d2f;hb=cd7f9c874a8ad7e9cea14365a90df7ff616461c0 >>> >> >>> >> >>> >> On Wed, Aug 28, 2013 at 8:53 AM, Muhammad Gelbana < >>> m.gelb...@gmail.com >>> >> >wrote: >>> >> >>> >> > I totally agree with Kalle. It will take time to digest all these >>> >> changes. >>> >> > Will there be a comprehensive documentation about the new stuff in >>> 5.4 ? >>> >> > >>> >> > *---------------------* >>> >> > *Muhammad Gelbana* >>> >> > Java Software Engineer >>> >> > >>> >> > >>> >> > On Wed, Aug 28, 2013 at 12:25 AM, Kalle Korhonen < >>> >> > kalle.o.korho...@gmail.com >>> >> > > wrote: >>> >> > >>> >> > > Howard, you are nuts! Thanks for all the hard work. We probably >>> need >>> >> to >>> >> > > give at least a few weeks to let everybody digest these changes, >>> what >>> >> do >>> >> > > you think about the public beta release? >>> >> > > >>> >> > > Kalle >>> >> > > >>> >> > > >>> >> > > On Tue, Aug 27, 2013 at 2:41 PM, Howard Lewis Ship < >>> hls...@gmail.com> >>> >> > > wrote: >>> >> > > >>> >> > > > This release swaps out Bootstrap 2.3.2 for Bootstrap 3.0. The >>> >> > > ControlGroup >>> >> > > > mixin has been renamed to FormGroup. A new Glyphicon component >>> has >>> >> been >>> >> > > > added. >>> >> > > > >>> >> > > > The tapestry-wro4j module has been renamed to >>> >> tapestry-webresources; it >>> >> > > > does the same job, but without the dependency on WRO4J. >>> >> > > > >>> >> > > > All of the Bootstrap JavaScript libraries are now separate, so >>> you >>> >> can >>> >> > > just >>> >> > > > require in the exact code you need. e.g. >>> >> > > > javaScriptSupport.require("bootstrap-collapse"). >>> >> > > > >>> >> > > > The Autocomplete mixin has been re-written around Twitter >>> Typeahead. >>> >> > > > >>> >> > > > There's new improvements to how page activation occurs to help >>> >> ensure >>> >> > > that >>> >> > > > the supplied URL matches the available activate event handler. >>> >> > > > >>> >> > > > There's also been a host of improvements and fixes on both the >>> >> > > client-side >>> >> > > > and the server-side. >>> >> > > > >>> >> > > > Tapestry preview releases are available via Maven, from the >>> Apache >>> >> > > > Staging repository: >>> >> > > > >>> >> > > > https://repository.apache.org/content/groups/staging >>> >> > > > >>> >> > > > -- >>> >> > > > Howard M. Lewis Ship >>> >> > > > >>> >> > > > Creator of Apache Tapestry >>> >> > > > >>> >> > > > The source for Tapestry training, mentoring and support. >>> Contact me >>> >> to >>> >> > > > learn how I can get you up and productive in Tapestry fast! >>> >> > > > >>> >> > > > (971) 678-5210 >>> >> > > > http://howardlewisship.com >>> >> > > > >>> >> > > >>> >> > >>> >> >>> >> >>> >> >>> >> -- >>> >> Howard M. Lewis Ship >>> >> >>> >> Creator of Apache Tapestry >>> >> >>> >> The source for Tapestry training, mentoring and support. Contact me to >>> >> learn how I can get you up and productive in Tapestry fast! >>> >> >>> >> (971) 678-5210 >>> >> http://howardlewisship.com >>> >> >>> >> >>> > >>> > >>> > -- >>> > Howard M. Lewis Ship >>> > >>> > Creator of Apache Tapestry >>> > >>> > The source for Tapestry training, mentoring and support. Contact me to >>> > learn how I can get you up and productive in Tapestry fast! >>> > >>> > (971) 678-5210 >>> > http://howardlewisship.com >>> > >>> >>> >>> >>> -- >>> Howard M. Lewis Ship >>> >>> Creator of Apache Tapestry >>> >>> The source for Tapestry training, mentoring and support. Contact me to >>> learn how I can get you up and productive in Tapestry fast! >>> >>> (971) 678-5210 >>> http://howardlewisship.com >>> >>> >> >> >> -- >> Dmitry Gusev >> >> AnjLab Team >> http://anjlab.com >> > > > > -- > Dmitry Gusev > > AnjLab Team > http://anjlab.com > -- Dmitry Gusev AnjLab Team http://anjlab.com