On Fri, Apr 20, 2012 at 11:44 AM, Norman Franke <[email protected]> wrote: > I'm in the process of upgrading from tapestry-security 0.3.1 to 0.4.4. Other > than the two extra dependencies, I'm having problems with my custom login > form. > This no longer works now that it's storing the URL in a cookie. Looking at > LoginForm.java, I see this code that sort of works: > However, the entire PageService interface is deprecated and the comments > note an indent to remove it. What's the proper way to do this? It would be > nice to have a single call to redirect on success, or at least have > getSuccessPage return a proper URL. > I'll do what LoginForm does for now, but I hate using deprecated APIs.
Yes, sorry about that, but that's the way to do it. There's no great way of indicating reasons for deprecation in javadoc. However, I wanted to include a warning for the current users of PageService that it's going to change in the future. First of all, I hate the name, it's too generic (and I should have deprecated it right away back when I started working on this codebase) and I'm not entirely convinced there's a need for a separate service in addition to the SecurityService. Also, I've found out that forward-looking deprecations is a great way of extorting comments from otherwise happy but quiet users of the module :P I didn't want to make drastic changes in 0.4.x until I've experimented with a cleaner api in 0.5. Kalle --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
