Hi Kalle, Merging this with tynamo? Why not. You can email me what needs to be done.
Although before we do it I would like at lest to make some tests to make the module at least half decent. I'm thinking it would also be nice to have support for ALL ckeditor features like image and flash upload on the server, but you can make a priority list if you are more familiar with what would be most useful to be implemented first. I'm willing to spend time working on them. Cheers, Dragan Sahpaski On Thu, Mar 1, 2012 at 4:51 AM, Kalle Korhonen <kalle.o.korho...@gmail.com>wrote: > On Sat, Feb 18, 2012 at 10:11 AM, Dragan Sahpaski > <dragan.sahpa...@gmail.com> wrote: > > Hey Kalle, > > See the latest commit. It resolves this issues properly. > > On each ajax zone update a new ckeditor instance is created and the old > > ones are properly destoyed using ckeditorinstance.destroy(). Also the > > attached event handlers on FORM_PREPARE_FOR_SUBMIT_EVENT are removed. > > Thanks Dragan, looking good now. > > > Also if you have some ideas what would be the easiest way for this small > > project to be published on maven central please share. > > Well, the easiest is to host the code with an organization (e.g. > codehaus) that has the necessary infrastructure set up already to push > to central. However, it's not too bad to sign up with Sonatype's OSSRH > (see > https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide > ) > using your own group id, assuming you plan to continue using > com.plannow.tapestry5 as the groupid. As a third option, or more > accurately, as an extension of the first option, perhaps we could make > it a new Tynamo.org module. I've purposefully avoided involving Tynamo > with UI component business but it might just make sense to make an > exception in this case especially since I kind of decided already to > go ahead with implementing the "light CMS" editable content concept > (which I described in another thread) myself since it'd take too long > as a GSoC project with unpredictable results for my needs. In any > case, the CKEditor component is good enough for my needs. > > Kalle > > > > On Fri, Feb 17, 2012 at 10:32 PM, Kalle Korhonen < > kalle.o.korho...@gmail.com > >> wrote: > > > >> On Fri, Feb 17, 2012 at 12:33 PM, Dragan Sahpaski > >> <dragan.sahpa...@gmail.com> wrote: > >> > OK I see it. After merging the pull request the changes are not saved > at > >> > all. Previously the field gets updated although an errors in the > >> javascript > >> > console are thrown upon zone update. > >> > >> After merging mine you mean? Yes, that may be the case, but in > >> principle that's correct way of updating the field and it just makes > >> the underlying problem visible. Before, "the interesting effects" I > >> mentioned meant that the field might have been updated with the > >> contents of the previous zone update, or it might not update all, > >> depending on which editor instance the user got. The bottom line is > >> that if there are multiple editor instances associated with the same > >> element, it's going to blow up sooner or later. > >> > >> > I'm on it and will get back to you tomorrow, hopefully with a > solution. > >> > >> No problem - perhaps you can just check if an editor instance exists > >> already. For my use case, it's enough that I get the contents via xhr > >> post, I don't need the editor field to be in the zone. > >> > >> Kalle > >> > >> > >> > On Fri, Feb 17, 2012 at 5:02 PM, Kalle Korhonen > >> > <kalle.o.korho...@gmail.com>wrote: > >> > > >> >> On Fri, Feb 17, 2012 at 4:42 AM, Dragan Sahpaski > >> >> <dragan.sahpa...@gmail.com> wrote: > >> >> > I'm not quite following you. I've successfully tested it with > multiple > >> >> > editors in one zone with form and it's ok. > >> >> > Can you send me an example page which has this problem? I promise > to > >> look > >> >> > at it right away. > >> >> > >> >> Odd then, I get multiple editors (and I mean multiple internal > >> >> CKeditor instances, not visible editors) if I just do: > >> >> <t:zone t:id="textAreaZone"> > >> >> <t:form id="textAreaForm" t:zone="textAreaZone"> > >> >> <t:errors/> > >> >> <t:textArea id="textArea" t:mixins="pn/CKEditor" > >> >> value="textValue" > >> >> parameters="{'toolbar': 'Basic'}" /> > >> >> <input type="submit" value="OK"/> > >> >> </t:form> > >> >> <p><t:outputRaw value="textValue"/></p> > >> >> </t:zone> > >> >> > >> >> Now if I just zone in the outputRaw, things work as expected. I'm > >> >> returning a zone.getBody from onSuccess(). I really didn't have any > >> >> existing code, I was just trying out different editor components on > an > >> >> empty archetype. > >> >> > >> >> Kalle > >> >> > >> >> > >> >> > >> >> > On Fri, Feb 17, 2012 at 9:05 AM, Kalle Korhonen > >> >> > <kalle.o.korho...@gmail.com>wrote: > >> >> > > >> >> >> Ah well, partly a user error. If you have the component (mixin) > >> >> >> wrapped in a zone, you'll get multiple instances of CKEditor with > >> >> >> plenty of interesting effects. It does make sense not to > >> re-initialize > >> >> >> it during ajax updates but wasn't ready to spend enough time to > find > >> >> >> the appropriate place to add safeguards to prevent multiple > instances > >> >> >> within the same zone. Sent a pull request anyway for a minor > clean-up > >> >> >> while I was working on it. > >> >> >> > >> >> >> Kalle > >> >> >> > >> >> >> > >> >> >> On Thu, Feb 16, 2012 at 4:52 PM, Kalle Korhonen > >> >> >> <kalle.o.korho...@gmail.com> wrote: > >> >> >> > Hey Dusko, Dragan, can tapestry5-ckeditor be configured to work > >> with > >> >> >> > ajax forms? I was hoping to use your component as part of a new > >> >> >> > project. I had hacked chenillekit's fckeditor a few years go to > >> work > >> >> >> > with ajax and I imagine this might need similar type of > treatment > >> if > >> >> >> > it's not already supported. > >> >> >> > > >> >> >> > Kalle > >> >> >> > > >> >> >> > > >> >> >> > On Fri, Nov 11, 2011 at 10:16 AM, Dusko Jovanovski < > >> dusk...@gmail.com > >> >> > > >> >> >> wrote: > >> >> >> >> You can try out our implementation: > >> >> >> >> https://github.com/plannowtech/tapestry5-ckeditor > >> >> >> >> > >> >> >> >> It's still not thoroughly tested, but should work fine. > >> >> >> >> > >> >> >> >> Any remarks/complaints/bugs should be reported on GitHub. > >> >> >> >> > >> >> >> >> -- > >> >> >> >> Dusko Jovanovski > >> >> >> >> > >> >> >> >> On Fri, Nov 11, 2011 at 4:50 AM, TG <tapestry...@hotmail.com> > >> wrote: > >> >> >> >> > >> >> >> >>> Do we have one? If so, any link to setup and download it? I > don't > >> >> use > >> >> >> Maven > >> >> >> >>> just FYI. > >> >> >> >>> > >> >> >> >>> Thanks. > >> >> >> >>> > >> >> >> >>> -- > >> >> >> >>> View this message in context: > >> >> >> >>> > >> >> >> > >> >> > >> > http://tapestry.1045711.n5.nabble.com/fckeditor-for-Tapestry-5-3-tp4983201p4983201.html > >> >> >> >>> Sent from the Tapestry - User mailing list archive at > Nabble.com. > >> >> >> >>> > >> >> >> >>> > >> >> --------------------------------------------------------------------- > >> >> >> >>> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > >> >> >> >>> For additional commands, e-mail: > users-h...@tapestry.apache.org > >> >> >> >>> > >> >> >> >>> > >> >> >> > >> >> >> > --------------------------------------------------------------------- > >> >> >> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > >> >> >> For additional commands, e-mail: users-h...@tapestry.apache.org > >> >> >> > >> >> >> > >> >> > >> >> --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > >> >> For additional commands, e-mail: users-h...@tapestry.apache.org > >> >> > >> >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > >> For additional commands, e-mail: users-h...@tapestry.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > >
