It seems that hibernate (unlike JDBC) uses zero based query parameter
indexes.
Use query.setLong(i, value) instead of i+1
All of your code should reference the interface (CategoryDao) instead of
the concrete class (HibernateCategoryDao). This will help in testing
(mocking interfaces is easy) and will also allow you to use the tapestry
registry (since tapestry creates a proxy that wraps and lazy loads the
underlying concrete implementation providing all sorts of goodies)
On Friday, 17 February 2012, George Christman <gchrist...@cardaddy.com>
wrote:
> I agree Lance, once we get this working I think it should be added to
> jumpstart. This is a very complex component. I was able to fix the
majority
> of issues you found. I wasn't clear on referencing the dao interface as
> opposed to using a concrete interface. I don't know the difference.
>
> I did make further progress with the query, I fixed the count exception
> with count(c2.id).
>
> "select c1.id, count(c2.id) "
> + "from CATEGORY c1 "
> + "left join CATEGORY c2 on c2.parentCategoryId = c1.id "
> + "where c1.id in (" + questions + ") "
> + "group by c1.id");
>
> Then I ran into this crazy exception
>
> Failure reading parameter 'model' of component Tree:tree: Positional
> parameter does not exist: 1 in query: select c1.id, count(c2.id) from
> CATEGORY c1 left join CATEGORY c2 on c2.parentCategoryId = c1.id where
> c1.idin (?) group by
> c1.id
>
> posted this question on StackOver Flow
>
http://stackoverflow.com/questions/9322883/hibernate-positional-parameter-does-not-exist-1-in-query
>
> and found this
> https://hibernate.onjira.com/browse/HHH-2254
>
> Good news is I seen the root nodes by accident when I commented out the
> query lol, if only their was some children to go along with it :)
>
> On Thu, Feb 16, 2012 at 4:00 AM, Lance Java [via Tapestry] <
> ml-node+s1045711n5488926...@n5.nabble.com> wrote:
>
>> Just taking another look I can see a couple of issues.
>>
>> 1. Are categoryId and parentCategoryId long's? If so, findById() should
>> take a long (not a string). If they are strings, the query should use
>> setString() instead of setLong(). Something has to change ;)
>>
>> 2. getChildren() should use Restrictions.eq("parentCategoryId",
>> note.getCategory().getId())
>>
>> 3. CategoryTreeModelAdapter should reference the interface of the DAO,
not
>> the concrete type.
>>
>> 4. In your page, you probably don't need a variable to store the
TreeModel
>> (the getter should be sufficient).
>>
>> 5. As I said earlier, the DAO might be better off being declared in the
>> Tapestry IOC registry. This would mean it's a singleton and can be
>> @Inject'ed. I'd do this after getting everything else working.
>>
>> Once you have a working example, please post it back to the list. I think
>> this sounds like a prime candidate for adding to JumpStart (
>> http://jumpstart.doublenegative.com.au)
>>
>> On Thursday, 16 February 2012, Lance Java <[hidden email]<
http://user/SendEmail.jtp?type=node&node=5488926&i=0>>
>> wrote:
>> > Hi George
>> >
>> > As I said, my hibernate is a bit rusty. What I have given you there is
a
>> JDBC query where each question mark represents a parameter which is later
>> set by Query.setLong(int paramIndex, Long value). You might need to
>> research or chat on hibernate forums to turn it into a hibernate friendly
>> query. Actually, I just looked at the hibernate javadoc and it says that
>> it
>> supports JDBC style '?' parameters so it might just work but I'm not
100%.
>> You could always look at using a hibernate criteria query and using a
>> projection to get the count() of children. Again, ask on the hibernate
>> forums for this.
>> >
>> > <rant>
>> > I actually really dislike hibernate because I think it makes smart
>> people
>> write stupid code. I have turned on SQL logging on hibernate applications
>> only to be disgusted by seeing many unnecessary extra queries, joins and
>> n+1 selects issues. If the developers were coding their queries by hand,
>> this would have never happened. I happen to prefer iBatis / myBatis for
>> it's hands on approach. Since the db is often the slowest component in
>> your
>> system, I hate to be so far abstracted from it.
>> > </rant>
>> >
>> > Apart from that your code looks ok although I would probably make the
>> DAO
>> a service and add it to Tapestry's IOC registry and then @Inject the DAO.
>> What you have at the moment should work though so it's probably best to
>> get
>> the query working first.
>> >
>> > Good luck,
>> > Lance.
>> >
>> > On Thursday, 16 February 2012, George Christman <[hidden email]<
http://user/SendEmail.jtp?type=node&node=5488926&i=1>>
>>
>> wrote:
>> >> Hi Lance, I'd like to share my progress with you. I think it will work
>> once
>> >> we get the hibernate sql query corrected. If you wouldn't mind taking
a
>> >> brief look at my classes to be sure I implemented everything
correctly,
>> it
>> >> would be greatly appreciated. I could always get a little assistance
>> from
>> >> the hibernate guys too if we can't figure out that query. I seen a ?
in
>> the
>> >> question stringbuilder method. Is that a place holder or is there some
>> kind
>>
>> >> of logic behind it. Once again thanks,
>> >>
>> >> Cheers,
>> >> George
>> >>
>> >> @Entity
>> >> public class Category extends BaseEntity {
>> >>
>> >> private String label;
>> >>
>> >> @OneToMany(mappedBy = "parentCategoryId")
>> >> private List<Category> children;
>> >>
>> >> @ManyToOne
>> >> @JoinColumn(name = "parent_id")
>> >> private Category parentCategoryId;
>> >>
>> >> //Getters Setters
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> public class CategoryNode {
>> >>
>> >> private Category category;
>> >> private boolean isLeaf;
>> >> private boolean hasChildren;
>> >>
>> >> //Getters Setters
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> public class HibernateCategoryDao implements CategoryDao {
>> >>
>> >> private final Session session;
>> >>
>> >> public HibernateCategoryDao(Session session) {
>> >> this.session = session;
>> >> }
>> >>
>> >> // this will be called by ValueEncoder.toValue(id)
>> >> public CategoryNode findById(String id) {
>> >> return findByCriterion(Restrictions.eq("categoryId",
>> >> id)).iterator().next();
>> >> }
>> >>
>> >> // this will be called by TreeModelAdapter.getChildren(CategoryNode
>> >> node)
>> >> public List<CategoryNode> getChildren(CategoryNode node) {
>> >> return findByCriterion(Restrictions.eq("parentCategoryId",
>> >> node.getCategory()));
>> >> }
>> >>
>> >> // this will be called by your page
>> >> public List<CategoryNode> findRoots() {
>> >> return
findByCriterion(Restrictions.isNull("parentCategoryId"));
>> >> }
>> >>
>> >> @SuppressWarnings("unchecked")
>> >> protected List<CategoryNode> findByCriterion(Criterion criterion) {
>> >> List<Category> cats =
>> >> session.createCriteria(Category.class).add(criterion).list();
>> >> Map<Integer, CategoryNode> childNodes = new
>> LinkedHashMap<Integer,
>> >> CategoryNode>();
>> >> for (Category cat : cats) {
>> >> CategoryNode childNode = new CategoryNode();
>> >> childNode.setCategory(cat);
>> >> childNodes.put(cat.getId(), childNode);
>> >> }
>> >> StringBuilder questions = new StringBuilder();
>> >> for (int i = 0; i < childNodes.size(); ++i) {
>> >> if (i != 0) {
>> >> questions.append(", ");
>> >> }
>> >> questions.append("?");
>> >> }
>> > ------------------------------
>> If you reply to this email, your message will be added to the discussion
>> below:
>>
>>
http://tapestry.1045711.n5.nabble.com/Tapestry-TreeGrid-tp5462126p5488926.html
>> To unsubscribe from Tapestry TreeGrid, click here<
http://tapestry.1045711.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=5462126&code=Z2NocmlzdG1hbkBjYXJkYWRkeS5jb218NTQ2MjEyNnwxNjMyOTYxMjA3
>
>> .
>> NAML<
http://tapestry.1045711.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
>
>>
>
>
>
> --
> George Christman
> www.CarDaddy.com
> P.O. Box 735
> Johnstown, New York
>
>
> --
> View this message in context:
http://tapestry.1045711.n5.nabble.com/Tapestry-TreeGrid-tp5462126p5491538.html
> Sent from the Tapestry - User mailing list archive at Nabble.com.
