On Fri, Jan 27, 2012 at 3:58 PM, Paul Stanton <p...@mapshed.com.au> wrote: > my 2c: the symbols > > tapestry.compress-whitespace > tapestry.enable-minification > > should not default to true (in production mode) since they both are known to > cause issues.
Looks like someone isn't writing tests. Part of the point of Tapestry is to make it good for developers during development without making it bad for production. Compressing whitespace and JS aggregation/minification are both important for production, but in the case of minification, Tapestry is standing on some shakey ground (the yui-compressor library that doesn't always work). I changed 5.3 late on to fall back to unminimized if the minification step fails. In terms of whitespace; only a very few bits of HTML will ever care, and Tapestry gives you the tools to get the same rendering in development as in production, via xml:space="preserve" on the critical elements. > > p. > > > On 5/01/2012 3:51 AM, Howard Lewis Ship wrote: >> >> https://issues.apache.org/jira/browse/TAP5-1729 >> >> >> On Wed, Jan 4, 2012 at 8:22 AM, Howard Lewis Ship <hls...@gmail.com >> <mailto:hls...@gmail.com>> wrote: >> >> There's been some issues about this when using >> tapestry-yuicompressor in some app servers, such as JBoss. Can >> you provide details on exactly what your environment is? >> >> >> On Wed, Jan 4, 2012 at 6:08 AM, Thim Anneesens >> <t.anneess...@ictjob.be <mailto:t.anneess...@ictjob.be>> wrote: >> >> Hello everybody. I have an issue in production mode. I get the >> following exception (see below) for each page request, but the >> page display without problem. >> I am fairly new to Tapestry but this looks like a bug. If >> anyone has information about this behaviour, feel free to reply. >> >> Best regards, >> Thim. >> >> [ERROR] AssetsModule.ResourceMinimizer Exception minimizing 'core' >> JavaScript stack, for locale en, >> resources=classpath:org/apache/tapestry5/underscore_1_1_7.js, >> classpath:org/apache/tapestry5/scriptaculous_1_9_0/prototype.js, >> classpath:org/apache/tapestry5/scriptaculous_1_9_0/scriptaculous.js, >> classpath:org/apache/tapestry5/scriptaculous_1_9_0/effects.js, >> classpath:org/apache/tapestry5/t5-core.js, >> classpath:org/apache/tapestry5/t5-spi.js, >> classpath:org/apache/tapestry5/t5-prototype.js, >> classpath:org/apache/tapestry5/t5-init.js, >> classpath:org/apache/tapestry5/t5-pubsub.js, >> classpath:org/apache/tapestry5/t5-events.js, >> classpath:org/apache/tapestry5/t5-dom.js, >> classpath:org/apache/tapestry5/t5-console.js, >> classpath:org/apache/tapestry5/t5-ajax.js, >> classpath:org/apache/tapestry5/t5-formfragment.js, >> classpath:org/apache/tapestry5/t5-alerts.js, >> classpath:org/apache/tapestry5/tapestry.js, >> classpath:org/apache/tapestry5/tapestry-console.js, >> classpath:org/apache/tapestry5/tr >> ee.js, classpath:org/apache/tapestry5/tapestry-messages.js: >> java.util.EmptyStackException >> >> java.util.EmptyStackException >> >> at java.util.Stack.peek(Stack.java:85) >> >> at >> com.yahoo.platform.yui.compressor.JavaScriptCompressor.getCurrentScope(JavaScriptCompressor.java:559) >> >> at >> com.yahoo.platform.yui.compressor.JavaScriptCompressor.printSymbolTree(JavaScriptCompressor.java:1105) >> >> at >> com.yahoo.platform.yui.compressor.JavaScriptCompressor.compress(JavaScriptCompressor.java:553) >> >> at >> org.apache.tapestry5.internal.yuicompressor.JavaScriptResourceMinimizer.doMinimize(JavaScriptResourceMinimizer.java:99) >> >> at >> org.apache.tapestry5.internal.yuicompressor.AbstractMinimizer$1.perform(AbstractMinimizer.java:67) >> >> at >> org.apache.tapestry5.internal.TapestryInternalUtils$5.run(TapestryInternalUtils.java:582) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:51) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:48) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:74) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:47) >> >> at >> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.run(PerThreadOperationTracker.java:76) >> >> at >> org.apache.tapestry5.ioc.internal.RegistryImpl.run(RegistryImpl.java:1116) >> >> at >> org.apache.tapestry5.internal.TapestryInternalUtils.performIO(TapestryInternalUtils.java:576) >> >> at >> org.apache.tapestry5.internal.yuicompressor.AbstractMinimizer.minimize(AbstractMinimizer.java:61) >> >> at >> org.apache.tapestry5.internal.services.assets.MasterResourceMinimizer.minimize(MasterResourceMinimizer.java:44) >> >> at $ResourceMinimizer_1e26fac6ff30b.minimize(Unknown Source) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.assembleStackContent(StackAssetRequestHandler.java:175) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.assembleStackContent(StackAssetRequestHandler.java:163) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getUncompressedResource(StackAssetRequestHandler.java:146) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getCompressedResource(StackAssetRequestHandler.java:132) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.getResource(StackAssetRequestHandler.java:123) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.access$100(StackAssetRequestHandler.java:40) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler$1.perform(StackAssetRequestHandler.java:103) >> >> at >> org.apache.tapestry5.internal.TapestryInternalUtils$5.run(TapestryInternalUtils.java:582) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:51) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:48) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:74) >> >> at >> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:47) >> >> at >> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.run(PerThreadOperationTracker.java:76) >> >> at >> org.apache.tapestry5.ioc.internal.RegistryImpl.run(RegistryImpl.java:1116) >> >> at >> org.apache.tapestry5.internal.TapestryInternalUtils.performIO(TapestryInternalUtils.java:576) >> >> at >> org.apache.tapestry5.internal.services.assets.StackAssetRequestHandler.handleAssetRequest(StackAssetRequestHandler.java:96) >> >> at >> org.apache.tapestry5.internal.services.AssetDispatcher.dispatch(AssetDispatcher.java:114) >> >> at $Dispatcher_1e26fac6ff300.dispatch(Unknown Source) >> >> at $Dispatcher_1e26fac6ff304.dispatch(Unknown Source) >> >> at $Dispatcher_1e26fac6ff2fe.dispatch(Unknown Source) >> >> at >> org.apache.tapestry5.services.TapestryModule$RequestHandlerTerminator.service(TapestryModule.java:302) >> >> at >> org.apache.tapestry5.internal.services.RequestErrorFilter.service(RequestErrorFilter.java:26) >> >> at $RequestHandler_1e26fac6ff2ff.service(Unknown Source) >> >> at >> org.apache.tapestry5.services.TapestryModule$3.service(TapestryModule.java:902) >> >> at $RequestHandler_1e26fac6ff2ff.service(Unknown Source) >> >> at >> org.apache.tapestry5.services.TapestryModule$2.service(TapestryModule.java:892) >> >> at $RequestHandler_1e26fac6ff2ff.service(Unknown Source) >> >> at >> org.apache.tapestry5.internal.services.StaticFilesFilter.service(StaticFilesFilter.java:90) >> >> at $RequestHandler_1e26fac6ff2ff.service(Unknown Source) >> >> at >> ictjob.frontend.services.AppModule$1.service(AppModule.java:112) >> >> at $RequestFilter_1e26fac6ff2fa.service(Unknown Source) >> >> at $RequestHandler_1e26fac6ff2ff.service(Unknown Source) >> >> at $RequestHandler_1e26fac6ff2f3.service(Unknown Source) >> >> at >> org.apache.tapestry5.services.TapestryModule$HttpServletRequestHandlerTerminator.service(TapestryModule.java:253) >> >> at >> org.apache.tapestry5.internal.gzip.GZipFilter.service(GZipFilter.java:53) >> >> at $HttpServletRequestHandler_1e26fac6ff2f5.service(Unknown >> Source) >> >> at >> org.apache.tapestry5.internal.services.IgnoredPathsFilter.service(IgnoredPathsFilter.java:62) >> >> at $HttpServletRequestFilter_1e26fac6ff2f1.service(Unknown >> Source) >> >> at $HttpServletRequestHandler_1e26fac6ff2f5.service(Unknown >> Source) >> >> at >> org.apache.tapestry5.services.TapestryModule$1.service(TapestryModule.java:852) >> >> at $HttpServletRequestHandler_1e26fac6ff2f5.service(Unknown >> Source) >> >> at $HttpServletRequestHandler_1e26fac6ff2f0.service(Unknown >> Source) >> >> at >> org.apache.tapestry5.TapestryFilter.doFilter(TapestryFilter.java:171) >> >> at >> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1333) >> >> at >> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:487) >> >> at >> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:119) >> >> at >> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:520) >> >> at >> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:233) >> >> at >> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:972) >> >> at >> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:417) >> >> at >> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:192) >> >> at >> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:906) >> >> at >> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117) >> >> at >> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:110) >> >> at org.eclipse.jetty.server.Server.handle(Server.java:350) >> >> at >> org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:442) >> >> at >> org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:910) >> >> at >> org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:565) >> >> at >> org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:217) >> >> at >> org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:46) >> >> at >> org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:545) >> >> at >> org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:43) >> >> at >> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:598) >> >> at >> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:533) >> >> at java.lang.Thread.run(Thread.java:662) >> >> -- *Thim Anneessens >> IT Department * >> >> ictjob group >> >> ictjob.be <http://www.ictjob.be> >> Tel: +32 2 725 73 00 <tel:%2B32%202%20725%2073%2000> >> Ikaroslaan, 2 >> B-1930 Zaventem ictjob.lu <http://www.ictjob.lu> >> Tel: +352 621 364 792 <tel:%2B352%20621%20364%20792> >> 12, rue Eugène Ruppert >> L-2453 Luxembourg jobtic.fr <http://www.jobtic.fr> >> Tel: +33 9 81 25 19 66 <tel:%2B33%209%2081%2025%2019%2066> >> 19 rue Martel >> 75010 Paris ticjob.es <http://www.ticjob.es> >> Tel: +34 911 25 43 11 <tel:%2B34%20911%2025%2043%2011> >> >> Calle Santo Tomé 4, 5B >> 28004 Madrid ictjob.de <http://www.ictjob.de> >> Tel: +49 711 91 41 07 32 <tel:%2B49%20711%2091%2041%2007%2032> >> >> Humboldtstr. 32 >> 70771 Leinfelden-Echterdingen >> >> >> >> >> -- Howard M. Lewis Ship >> >> Creator of Apache Tapestry >> >> The source for Tapestry training, mentoring and support. Contact >> me to learn how I can get you up and productive in Tapestry fast! >> >> (971) 678-5210 <tel:%28971%29%20678-5210> >> >> http://howardlewisship.com >> >> >> >> >> -- >> Howard M. Lewis Ship >> >> Creator of Apache Tapestry >> >> The source for Tapestry training, mentoring and support. Contact me to >> learn how I can get you up and productive in Tapestry fast! >> >> (971) 678-5210 >> http://howardlewisship.com -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
